PHP 8.1 compatiblity & Magento 2 tables update (utilities) #108

xtremevision · 2023-08-25T18:06:33Z

Fixed:

PHP 8.1 compatibility issues
Non-existent tables in Utillities -> Clean Catalog and Customers
Small UI fix (progress bar)

tmotyl · 2023-08-28T07:30:51Z

magmi/inc/remotefilegetter.php

@@ -262,6 +262,8 @@ public function getRemoteFile($url, $dest, $authmode = null, $cookies = null)
        $context = $this->createContext($url);
        $ch = $context['curlhandle'];
        $dl_opts = $context['opts']['dl'];
+
+        $dest = str_replace("pub/pub", "pub", $dest);


what is this change for?

tmotyl · 2023-08-28T07:31:39Z

magmi/plugins/extra/itemprocessors/imageprocessor/imageitattributeemprocessor.php

@@ -482,13 +483,19 @@ public function copyImageFile($imgfile, &$item, $extra)
        // magento image value (relative to media catalog)
        $impath = "/$i1/$i2/$bimgfile";
        // target directory;
-        $l2d = "pub/media/catalog/product/$i1/$i2";
+
+        if(!strstr(getcwd(), "pub"))


please add brackets around "if" body and
"else" body

tmotyl · 2023-08-28T07:32:29Z

magmi/plugins/utilities/clearproducts/clearproduct.php

@@ -38,7 +58,8 @@ public function runUtility()
        }

        //clean url rewrites for products
-        $sql = "DELETE FROM ".$this->tablename("core_url_rewrite")." WHERE product_id IS NOT NULL AND is_system=1";
+        //$sql = "DELETE FROM ".$this->tablename("core_url_rewrite")." WHERE product_id IS NOT NULL AND is_system=1";


please remove the comment

tmotyl

thanks for the patch. please fix some nitpics

xtremevision · 2023-08-28T13:48:43Z

Apologies, it's been a while since I made that fix, but if memory serves me right, it was because I experience great difficulties importing remote images. For some reason $dest was always "pub/pub" instead of just "pub" and even though the files got imported, they weren't being created/written in the right path, i.e. pub/media/catalog/product/... I am more than happy to fix it at source if you prefer, i.e. where getRemoteFile() is being called (or higher up), but this fix seemed the easiest/quickest, and safest. Example of import csv: "sku","type","name","url_key","description","short_description","categories","status","store","websites","attribute_set","retail_price","price","check_by_mail_price","ebay_auction_price","ebay_store_price","base _price","real_time_base_price_formula","material_content","material_price","material_price_date","live_pricing","margin_percent","markup_percent","mule","currency_other","currency_fr_number","currency_denominati on","currency_date_series","currency_type","currency_star","currency_error","currency_nbn_title","currency_nbn_city","currency_nbn_state","currency_nbn_ch","cc_material","cc_mintcode","is_ebay_item","is_collecto rs_corner_item","upc","cost","qty","meta_keyword","is_in_stock","visibility","tax_class_id","manage_stock","use_config_manage_stock","notify_stock_qty","max_sale_qty","qty_increments","cd_certification","cc_cert ificatenumber","grade","prefix_grade","cc_grade","cc_gradingservice","cd_denomination","cd_mintmark","cd_luster","cd_year","material","cd_condition","cd_eyeappeal","cd_cleaned","cd_strike","cd_description","is_b argain_bin","manufacturer","image","small_image","thumbnail","media_gallery" "BBDM13957","simple","1921-P Morgan Silver Dollar - ERROR Struck Thru","1921-p-morgan-silver-dollar-error-struck-thru-bbdm13957","","","Coins by Type/U.S. Dollars (1794-Present)/U.S. Morgan Dollars (1878-1904, 1 921)","1","default","base","COINSBARGAINBIN","47.00000","40.00000","39.00000","41.00000","41.00000","37.00000","","","","","0","45","81","","","","","","","","","","","","","Silver","P","1","1","","25.90000","1. 00000","1921-P, 247898, Do, Dollar, ERROR, Morgan, Silver, Struck, Thru","1","Catalog, Search","None","1","1","1","10000","1","","","","","","","Morgan Silver Dollar","P","","1921","Silver","Circulated","","","" ,"","1","US Mint"*,"http://url.com/IMAGES/2-23 FEBRUARY/021 BARGAIN BIN/011 DOLLARS/04 MORGAN/BBDM13957_1.PNG","http://url.com/IMAGES/2-23 FEBRUARY/021 BARGAIN BIN/011 DOLLAR** **S/04 MORGAN/BBDM13957_1.PNG","http://url.com/IMAGES/2-23 FEBRUARY/021 BARGAIN BIN/011 DOLLARS/04 MORGAN/BBDM13957_1.PNG","http://url.com/IMAGES/2-23 FEBRUARY/021 BARGAIN BIN** **/011 DOLLARS/04 MORGAN/BBDM13957_2.PNG"* magmi is installed in pub/magmi the import file is in pub/import/import.csv

On 28/08/2023 03:31, Tymoteusz Motylewski wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In magmi/inc/remotefilegetter.php <#108 (comment)>: > @@ -262,6 +262,8 @@ public function getRemoteFile($url, $dest, $authmode = null, $cookies = null) $context = $this->createContext($url); $ch = $context['curlhandle']; $dl_opts = $context['opts']['dl']; + + $dest = str_replace("pub/pub", "pub", $dest); what is this change for? — Reply to this email directly, view it on GitHub <#108 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABR3CEWUU74ZBXA6MWISWYTXXRCLNANCNFSM6AAAAAA362VSMU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Michael Mussulis mobilePhone + 1 772 418 3463 <tel:+%201%20772%20418%203463> emailAddress ***@***.*** ***@***.***> website https://www.linkedin.com/in/michaelmussulis/ <https://www.linkedin.com/in/michaelmussulis/>

xtremevision · 2023-08-28T13:54:33Z

Done.

On 28/08/2023 03:31, Tymoteusz Motylewski wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In magmi/plugins/extra/itemprocessors/imageprocessor/imageitattributeemprocessor.php <#108 (comment)>: > @@ -482,13 +483,19 @@ public function copyImageFile($imgfile, &$item, $extra) // magento image value (relative to media catalog) $impath = "/$i1/$i2/$bimgfile"; // target directory; - $l2d = "pub/media/catalog/product/$i1/$i2"; + + if(!strstr(getcwd(), "pub")) please add brackets around "if" body and "else" body — Reply to this email directly, view it on GitHub <#108 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABR3CETLPYFWOVLT6YPUW33XXRCORANCNFSM6AAAAAA362VSMU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Michael Mussulis mobilePhone + 1 772 418 3463 <tel:+%201%20772%20418%203463> emailAddress ***@***.*** ***@***.***> website https://www.linkedin.com/in/michaelmussulis/ <https://www.linkedin.com/in/michaelmussulis/>

xtremevision · 2023-08-28T13:54:41Z

Done.

On 28/08/2023 03:32, Tymoteusz Motylewski wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In magmi/plugins/utilities/clearproducts/clearproduct.php <#108 (comment)>: > @@ -38,7 +58,8 @@ public function runUtility() } //clean url rewrites for products - $sql = "DELETE FROM ".$this->tablename("core_url_rewrite")." WHERE product_id IS NOT NULL AND is_system=1"; + //$sql = "DELETE FROM ".$this->tablename("core_url_rewrite")." WHERE product_id IS NOT NULL AND is_system=1"; please remove the comment — Reply to this email directly, view it on GitHub <#108 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABR3CETEKFTJFVODUP56VHTXXRCRRANCNFSM6AAAAAA362VSMU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Michael Mussulis mobilePhone + 1 772 418 3463 <tel:+%201%20772%20418%203463> emailAddress ***@***.*** ***@***.***> website https://www.linkedin.com/in/michaelmussulis/ <https://www.linkedin.com/in/michaelmussulis/>

xtremevision · 2023-08-28T13:54:55Z

No problem. Done and pushed.

On 28/08/2023 03:33, Tymoteusz Motylewski wrote: ***@***.**** requested changes on this pull request. thanks for the patch. please fix some nitpics — Reply to this email directly, view it on GitHub <#108 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABR3CEWEKRG37INI7KDABQ3XXRCTPANCNFSM6AAAAAA362VSMU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Michael Mussulis mobilePhone + 1 772 418 3463 <tel:+%201%20772%20418%203463> emailAddress ***@***.*** ***@***.***> website https://www.linkedin.com/in/michaelmussulis/ <https://www.linkedin.com/in/michaelmussulis/>

tmotyl · 2023-09-08T08:39:07Z

there are plenty of error_log() calls, seems like they are a leftover from debugging?

xtremevision · 2023-09-08T12:30:54Z

Yes, I did have lots of error_log() calls but I removed them when I did committed. And I did 2 more commits after the first one. I just checked again and I can see I missed some. I'll clean them up and commit.

On 08/09/2023 04:39, Tymoteusz Motylewski wrote: there are plenty of error_log() calls, seems like they are a leftover from debugging? — Reply to this email directly, view it on GitHub <#108 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABR3CETTK5IK3MSID77TJ6DXZLKTNANCNFSM6AAAAAA362VSMU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Michael Mussulis mobilePhone + 1 772 418 3463 <tel:+%201%20772%20418%203463> emailAddress ***@***.*** ***@***.***> website https://www.linkedin.com/in/michaelmussulis/ <https://www.linkedin.com/in/michaelmussulis/>

xtremevision · 2023-09-08T12:36:35Z

Done. Please check now.

On 08/09/2023 04:39, Tymoteusz Motylewski wrote: there are plenty of error_log() calls, seems like they are a leftover from debugging? — Reply to this email directly, view it on GitHub <#108 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABR3CETTK5IK3MSID77TJ6DXZLKTNANCNFSM6AAAAAA362VSMU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Michael Mussulis mobilePhone + 1 772 418 3463 <tel:+%201%20772%20418%203463> emailAddress ***@***.*** ***@***.***> website https://www.linkedin.com/in/michaelmussulis/ <https://www.linkedin.com/in/michaelmussulis/>

Michael Mussulis added 2 commits August 25, 2023 13:52

Fixes for M2

68a9220

removed debug statements

dbae675

tmotyl reviewed Aug 28, 2023

View reviewed changes

tmotyl requested changes Aug 28, 2023

View reviewed changes

Minor fixes for PR

e4d42d2

Fixed new lines for phpcs

827d2c8

Removed more error_log() debug statements

8056e44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP 8.1 compatiblity & Magento 2 tables update (utilities) #108

PHP 8.1 compatiblity & Magento 2 tables update (utilities) #108

xtremevision commented Aug 25, 2023

tmotyl Aug 28, 2023

tmotyl Aug 28, 2023

tmotyl Aug 28, 2023

tmotyl left a comment

xtremevision commented Aug 28, 2023 via email

xtremevision commented Aug 28, 2023 via email

xtremevision commented Aug 28, 2023 via email

xtremevision commented Aug 28, 2023 via email

tmotyl commented Sep 8, 2023

xtremevision commented Sep 8, 2023 via email

xtremevision commented Sep 8, 2023 via email

PHP 8.1 compatiblity & Magento 2 tables update (utilities) #108

Are you sure you want to change the base?

PHP 8.1 compatiblity & Magento 2 tables update (utilities) #108

Conversation

xtremevision commented Aug 25, 2023

tmotyl Aug 28, 2023

Choose a reason for hiding this comment

tmotyl Aug 28, 2023

Choose a reason for hiding this comment

tmotyl Aug 28, 2023

Choose a reason for hiding this comment

tmotyl left a comment

Choose a reason for hiding this comment

xtremevision commented Aug 28, 2023 via email

xtremevision commented Aug 28, 2023 via email

xtremevision commented Aug 28, 2023 via email

xtremevision commented Aug 28, 2023 via email

tmotyl commented Sep 8, 2023

xtremevision commented Sep 8, 2023 via email

xtremevision commented Sep 8, 2023 via email