Workaround for trace infinity loop in exception handling #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I copied the workaround from macopedia#54 because the pr is not yet splitted and i needed the functionality.
|
Ive got the counter solution, looks ok, but why did you also change the dirname part? |
Oops, didnt see this while copying. I'll fix it |
tmotyl
requested changes
Jan 14, 2020
tmotyl
reviewed
Jan 15, 2020
magmi/inc/magmi_engine.php
Outdated
| @@ -409,7 +409,7 @@ public function getExceptionTrace($tk, &$traces) | |||
| } | |||
| } | |||
| // simple max trace depth fix | |||
| if (++$counter % 20) { | |||
| if (++$counter % 20 == 0) { | |||
There was a problem hiding this comment.
lets have === just for a sake of being clean.
tmotyl
approved these changes
Jan 16, 2020
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied the workaround from #54 because the pr is not yet splitted and i needed the functionality.