Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xsel: disable check for autoconf vfork AC_FUNC_FORK #13078

Merged
merged 1 commit into from
Dec 4, 2021
Merged

xsel: disable check for autoconf vfork AC_FUNC_FORK #13078

merged 1 commit into from
Dec 4, 2021

Conversation

derekschrock
Copy link
Contributor

@derekschrock derekschrock commented Nov 21, 2021 •
edited
Loading

  • disable check for autoconf AC_FUNC_FORK vfork checking caching to yes.
  • AC_FUNC_FORK will create a #define vfork fork macro in config.h
  • vfork has been mark depercated in macOS 12.
  • This macro will mark fork() usage as depercated due to
    config.h being included before system header <unistd.h>.

Re: kfish/xsel#42
Closes: https://trac.macports.org/ticket/63748

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.0.1, 10.15.6
Xcode 13.1, 12.4

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@derekschrock
xsel: disable check for autoconf vfork AC_FUNC_FORK
dad9cc5 
* disable check for autoconf AC_FUNC_FORK vfork checking caching to yes.
* AC_FUNC_FORK will create a `#define vfork fork` macro in config.h
* vfork has been mark depercated in macOS 12.
* This macro will mark fork() usage as depercated due to
  config.h being included before system header <unistd.h>.

Re: kfish/xsel#42
Closes: https://trac.macports.org/ticket/63748
@macportsbot
Copy link

Notifying maintainers:
@ryandesign for port xsel.

@macportsbot macportsbot added the maintainer: open Affects an openmaintainer port label Nov 21, 2021
@mascguy
Copy link
Member

mascguy commented Nov 21, 2021

Derek, just started the CI jobs for you. And since this is your first contribution, we wish you a warm welcome from the entire MacPorts family!

@mascguy mascguy self-assigned this Nov 21, 2021
@ra1nb0w
Copy link
Contributor

ra1nb0w commented Dec 4, 2021

Maintainer timeout and reading the trac comments when can merge.

@ra1nb0w ra1nb0w merged commit a5e2d3e into macports:master Dec 4, 2021
@ra1nb0w
Copy link
Contributor

ra1nb0w commented Dec 4, 2021

thank you @derekschrock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryandesign ryandesign

@mascguy mascguy

Labels
maintainer: open Affects an openmaintainer port
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@derekschrock @macportsbot @mascguy @ra1nb0w @ryandesign