snownews: fix build on darwin < 16 #26018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandesign
reviewed
Sep 30, 2024
| ${exe}: ${objs} | ||
| @echo "Linking $@ ..." | ||
| - @${CC} ${ldflags} -o $@ $^ ${libs} | ||
| + @${CC} ${ldflags} -o $@ $^ ${libs} -lMacportsLegacySupport |
There was a problem hiding this comment.
You shouldn't need to do this manually. It suggests that something else is wrong, for example that the LDFLAGS that MacPorts tells the port to use are not be getting used. That's what needs to be fixed, because it will fix not only this problem but also other problems associated with LDFLAGS not being used (non-default-arch builds failing, for example). See https://trac.macports.org/ticket/65427.
There was a problem hiding this comment.
It does not link to legacysupport by default, yeah. Perhaps because it does not use standard ways to pass flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It fails to pass ldflag to legacy-support. Do it manually.
Type(s)
Tested on
macOS 10.6
Xcode 3.2
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?