ZSH - changed dependancy pcre->pcre2 since pcre is not compiling #26023
Conversation
|
Notifying maintainers: |
| @@ -21,7 +21,7 @@ homepage https://www.zsh.org | |||
| depends_lib port:gdbm \ | |||
| port:libiconv \ | |||
| port:ncurses \ | |||
| port:pcre | |||
| port:pcre2 | |||
There was a problem hiding this comment.
Changing a library dependency requires a "revision" increase.
There was a problem hiding this comment.
And also usually some change in configure flags or other way of controlling which libraries are used.
|
and your commit message doesn't follow our guidelines. It should be "portname: short description"; the port name isn't capitalized either. |
|
@Behinder please take care of the review comments and rebase with "masfer" to get rid of the merge conmit |
|
We are not aware that "pcre is not compiling"; if this is your experience, please file a bug report about it. |
There was a problem hiding this comment.
also, you didn't actually address @jmroot his comment about making sure that it will use/link with "pcre2".
| @@ -49,7 +49,7 @@ checksums ${main_distfile} \ | |||
| # See e.g. https://trac.macports.org/ticket/60419 | |||
|
|
|||
| # DO NOT change this unless you have understood and acted on the above comment! | |||
| set py_ver 3.10 | |||
| set py_ver 3.12 | |||
There was a problem hiding this comment.
did you read the comment above and made absolutely sure that nothing would break with this change?
There was a problem hiding this comment.
Things will definitely break with that change, and it doesn't seem related to the rest of this PR.
Description
Type(s)
Tested on