-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wezterm: Update to sha 30345b36d8a00fed347e4df5dadd83915a7693fb #26026
base: master
Are you sure you want to change the base?
Conversation
Notifying maintainers: |
This sha I picked was the HEAD at a random time. We should pick at the current head as of some date, like today, or the first SHA after the last release that works on sequoia. I like the idea of using the current head with a comment saying to update it when the release happens. The current head would be wez/wezterm@a2f2c07 |
well... typically a port should install an version released by upstream, not some random git commit hash. If earlier releases don't work on the latest macOS version it might be time to try and persuade upstream to tag a nee version. If you want to follow upstream development that should be done in a "-devel" subport. Let's leave a decision in this to the port maintainer @herbygillot |
Yeah - I have a git stash just to bring in a SHA that works, but a -devel might not be a bad idea. I can open an issue upstream about not building on 15, sadly since the binary release works and HEAD works, I anticipate some push back, but can't hurt to try. |
@@ -4,7 +4,7 @@ PortSystem 1.0 | |||
PortGroup cargo 1.0 | |||
PortGroup github 1.0 | |||
|
|||
github.setup wez wezterm 20240203-110809-5046fc22 | |||
github.setup wez wezterm 30345b36d8a00fed347e4df5dadd83915a7693fb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issue here is that the SHA version doesn't follow the same format as the version there currently.
So maybe we can do this, but explicitly set a datestamped current version with the assumption that the next release will have a higher (later) datestamp.
So perhaps something like this:
github.setup wez wezterm 30345b36d8a00fed347e4df5dadd83915a7693fb
version 20240813-000000-30345b36d8
20240813
is the datestamp of that commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a bad plan. We should decide if this is the SHA we want, too. I want to stress that this was just HEAD at the time I tested to see if it had been fixed upstream, and I've just run with it so far.
@herbygillot can you please take over this PR and get it merged? It's not going anywhere - otherwise I'll close it. |
Will do |
Description
Update
wezterm
to a newer (not yet released) upstream version. Closes https://trac.macports.org/ticket/70833 .Type(s)
Tested on
macOS 15.0 24A335 arm64
Xcode 16.0 16A242d
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?sudo port test
fails with a message that I do not understand. The error is