Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botan: Update to version 3.5.0.; Bugfix #26033

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

essandess
Copy link
Contributor

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

* Fixes CLT clang build issues
* Fixes: randombit/botan#4348
Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this a new major version. Did the library name change and/or have you verified that none of this ports dependents links to a versioned library?

@reneeotten
Copy link
Contributor

@essandess please respond so there is a chance to merge this PR...

@essandess
Copy link
Contributor Author

I started looking into this. KeePassXC's cmake file knows about botan version 3 but fails to build for other unrelated reasons. I ran into similar issues with monotone and qca. I'm not familiar enough with the downstream ports to be able to answer and expect that their build systems are able to detect the presence of botan, but cannot verify.

$ port echo depends:botan
KeePassXC                       
KeePassXC-devel                 
monotone                        
monotone-devel                  
qca                             
qca-qt5                         
qt4-creator-mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Current master fails to link on MacOS (Apple Silicon M2) with Xcode-16
2 participants