Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-pyobjc: fix Quartz module on macOS 15 #26229

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

breun
Copy link
Member

@breun breun commented Oct 20, 2024

Description

Fix build of Quartz module by setting deployment target to macOS 14 (see Sequoia Problems), because CGWindowListCreateImageFromArray is no longer available on macOS 15.

Type(s)
  • bugfix
Tested on

macOS 15.0.1 24A348 arm64
Xcode 16.0 16A242d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@danchr for port py-pyobjc.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Oct 20, 2024
@reneeotten
Copy link
Contributor

so which PR for py-pyobjc do you want to merge? I would think ideally one updates the port and then if this workaround is still needed do that as well?

@breun
Copy link
Member Author

breun commented Oct 23, 2024

This PR is the fix for the Quartz module which currently fails to build on macOS 15 and #26182 is the PR to update PyObjC to the latest version. The latest version still needs this workaround for the Quartz module.

If we merge this one first, I'll fix the other one up.

@reneeotten
Copy link
Contributor

just combine the two

@breun breun merged commit cb69623 into macports:master Oct 23, 2024
4 checks passed
@breun breun deleted the py-pyobjc-quartz-fix-for-macos-15 branch October 23, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

4 participants