1password: Update to provide completions on install

[halostatue]

Description

1password: Update to provide completions on install

Type(s)

• enhancement

Tested on

macOS 14.7.2 23H311
arm64 Xcode 16.2 16C5032a

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• checked your Portfile with port lint?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[macportsbot]

Notifying maintainers:
@herbygillot for port 1password-cli.
@newtonne for port 1password-cli.

[herbygillot]

@herbygillot I am unable to complete the testing on this one because for some reason the expand phase is hanging on me (I have to background and kill -9 to stop it). I may just need to reboot, but this shouldn't be hanging, because it isn't even hitting the new code yet:

:notice:extract --->  Extracting 1password-cli
:debug:extract Extracting to subdirectory worksrcdir
:debug:extract Executing org.macports.extract (1password-cli)
:info:extract --->  Extracting op_apple_universal_v2.30.3.pkg
:debug:extract setting option extract.args to '/opt/local/var/macports/distfiles/1password-cli/op_apple_universal_v2.30.3.pkg'
:debug:extract get_source_date_epoch: uncommitted changes to /…/macports-ports/security/1password-cli
:debug:extract Environment:
:debug:extract CC_PRINT_OPTIONS='YES'
:debug:extract CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_…_macports-ports_security_1password-cli/1password-cli/wor⏎

When I run the steps manually in my own directory, everything works just fine, but that doesn't help with macports.

Hey @halostatue, so I took a look and I'm seeing similar.

I think it's the completion generation that's hanging. We should move it out of post-extract, by the way. Perhaps have that happen in post-build?

post-build {
    foreach shell {bash fish zsh} {
        system -W ${pkg_workpath} \
          "./${bin_name} completion ${shell} > ${name}.${shell}"
    }
}

[halostatue]

I made a few more changes that I think make sense (to generate the completion scripts into a subdirectory of $worksrcpath instead of $pkg_workpath), but the solution appears to have been adding -nodup to the system command.

[herbygillot]

Good catch. Thank you @halostatue.