fix: ⚡ Added latest starknet-types-core release to support Starkh… #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trait + block number as Id new impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: ⚡ Added latest starknet-types-core release to support Starkhash
When testing the bonsai lib in production we face this problem due to the latest release of starknet-types-core not beeing deployed yet. This PR aims to support latest version of starknet-types-core along with a small impl on BasicId to easily retrieve and store commit ids based on
BlockNumber(u64)This PR has been tested against the first 500 Starknet mainnet blocks and works perfectly.