chore(deps): internalize rpc types #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbcaron
changed the title
Trantorian1
requested review from
Trantorian1,
cchudant,
notlesh,
Mohiiit,
HermanObst and
antiyro
Trantorian1
approved these changes
Feb 10, 2025
Comment on lines
1
to
20
| //! This crate is a fork of the original [starknet-types-rpc](https://github.com/starknet-io/types-rs) v0.7.1, | ||
| //! which was originally developed by the Starknet team under the MIT license. | ||
| //! | ||
| //! The original crate is no longer actively maintained, so this fork has been created | ||
| //! to ensure continued maintenance and compatibility with our project needs. | ||
| //! | ||
| //! Original authors: | ||
| //! - Pedro Fontana (@pefontana) | ||
| //! - Mario Rugiero (@Oppen) | ||
| //! - Lucas Levy (@LucasLvy) | ||
| //! - Shahar Papini (@spapinistarkware) | ||
| //! - Abdelhamid Bakhta (@abdelhamidbakhta) | ||
| //! - Dan Brownstein (@dan-starkware) | ||
| //! - Federico Carrone (@unbalancedparentheses) | ||
| //! - Jonathan Lei (@xJonathanLEI) | ||
| //! - Maciej Kamiński (@maciejka) | ||
| //! | ||
| //! Original repository: https://github.com/starknet-io/types-rs | ||
| //! Original version: 0.7.1 | ||
| //! License: MIT |
There was a problem hiding this comment.
Maybe add this in a .md at the crate level?
heemankv
reviewed
Feb 12, 2025
| @@ -291,10 +291,10 @@ impl Default for TrieLogConfig { | |||
| /// by subscribing to the corresponding channel. | |||
| pub struct EventChannels { | |||
| /// Broadcast channel that receives all events regardless of their sender's address | |||
| all_channels: tokio::sync::broadcast::Sender<EmittedEvent<Felt>>, | |||
There was a problem hiding this comment.
In https://github.dev/jbcaron/types-rs
v0_6_0 :
pub type BlockHash = Felt;
v0_7_1 :
pub type BlockHash<F> = F;
This PR's description says we are following v0_7_1 but the code suggests that we are falling back to v0_6_0,
Can you clear this confusion @jbcaron ?
Thanks
This seems to be followed throughout the PR.
- BroadcastedInvokeTxn
- EmittedEvent
- AddInvokeTransactionResult
and so on
There was a problem hiding this comment.
I’ve removed the genericity on Felt to simplify the codebase.
That’s why it might seem like we’re falling back to v0_6_0, but it’s intentional.
There was a problem hiding this comment.
Alright, I notice you have also updates the PR description,
looks good to me now!
heemankv
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Currently, Madara relies on the external starknet-types-rpc crate from the Starknet team, which is no longer actively maintained. This creates a dependency on an unmaintained third-party library for critical RPC types and functionality.
Resolves: #NA
What is the new behavior?
Key changes:
Feltto reduce complexityDoes this introduce a breaking change?
No
Other information