Fixes an issue affecting multi-line Text blocks #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, if the user would create new lines in a Text block by pressing Shift + Enter, when hitting the backspace key with the caret at the first position of any line (except the first one), the block would be merged into the previous one instead of merging the lines. Also, just the content one the first line would be kept.
|
Thanks @clementprdhomme I'll take a look at this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, if the user would create new lines in a
Textblock by pressing Shift + Enter, when hitting the backspace key with the caret at the first position of any line (except the first one), the block would be merged into the previous one instead of merging the lines. Also, just the content of the first line would be kept.You may want to create some tests so you won't have any regression at some point. I'm happy to help.
Link to the issue