Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate block positioner select data for performance reasons #563

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Separate block positioner select data for performance reasons #563

merged 3 commits into from
Mar 4, 2019

Conversation

raffij
Copy link
Contributor

@raffij raffij commented Feb 25, 2019

@raffij raffij marked this pull request as ready for review March 1, 2019 11:45
@raffij raffij requested a review from callum March 4, 2019 08:49
callum
callum approved these changes Mar 4, 2019
View reviewed changes
CHANGELOG.md Outdated
@@ -35,6 +35,10 @@

## 0.7.x

### 0.7.5

* Separate block positioner select data and make it a property of editor instead of block.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could reference the original issue here that details the problem, only because this doesn't explain why this change was made

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@raffij raffij mentioned this pull request Mar 4, 2019
Closed
@raffij raffij merged commit 2829949 into master Mar 4, 2019
@raffij raffij deleted the block_positioner branch March 4, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callum callum callum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raffij @callum @danielsarin