Fix protocol names #508
Merged
Fix protocol names #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
bug
madsmtm
force-pushed
the
fix-nsobjectprotocol
branch
5 times, most recently
from
57d7c75
to
664e0a0
Compare
It is more like an odd edge-case that `NSObject` implements `ProtocolType` and can be used as `ProtocolObject<NSObject>`, users should instead use `NSObjectProtocol` which works like any other protocol.
madsmtm
force-pushed
the
fix-nsobjectprotocol
branch
from
664e0a0
to
1ad018a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix protocol names of renamed protocols
NSObjectProtocol,NSAccessibilityElementProtocol,NSTextAttachmentCellProtocolandNSFileProviderItemProtocol.This also fixes the issue with declaring conformance to the
NSObjectProtocolindeclare_class!, so that's really nice!