Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual block encodings #636

Merged
merged 14 commits into from
Sep 17, 2024
Merged

Manual block encodings #636

merged 14 commits into from
Sep 17, 2024

Commits on Sep 16, 2024

  1. Feat+Refactor(block2/abi): Add new utils on BlockFlags 

    Signed-off-by: Paul Mabileau <[email protected]>
    @PaulDance
    PaulDance committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5387cab View commit details
    Browse the repository at this point in the history

  2. Feat(block2): Add new with_encoding unsafe block constructors 

    Signed-off-by: Paul Mabileau <[email protected]>
    @PaulDance
    PaulDance committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    56fc5fc View commit details
    Browse the repository at this point in the history

  3. Feat(encode): Add ability to compute block encoding string 

    Signed-off-by: Paul Mabileau <[email protected]>
    @PaulDance
    PaulDance committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7b2d824 View commit details
    Browse the repository at this point in the history

  4. Feat(block2): Add placeholders for safety debug assertions to manuall… 

    …y-encoded block constructors

As per the review: until the block encoding generation is done better.

Signed-off-by: Paul Mabileau <[email protected]>
    @PaulDance
    PaulDance committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c6bb5e1 View commit details
    Browse the repository at this point in the history

  5. Chore: Update compiler UI test 

     * `StackBlock`'s `Clone` constraint checks: order switch it seems.
 * `OptionEncode` compile-time checks: small line number shift.

Signed-off-by: Paul Mabileau <[email protected]>
    @PaulDance
    PaulDance committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    8793842 View commit details
    Browse the repository at this point in the history

  6. Test(ui): Extend block tests for with_encoding 

    Signed-off-by: Paul Mabileau <[email protected]>
    @PaulDance
    PaulDance committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6911801 View commit details
    Browse the repository at this point in the history

  7. Test(block): Extend tests for with_encoding 

    Signed-off-by: Paul Mabileau <[email protected]>
    @PaulDance
    PaulDance committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2d960ac View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Make test more generic

    @madsmtm
    madsmtm committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    af13f70 View commit details
    Browse the repository at this point in the history

  2. Avoid opt_double! macro, since it's unnecessary

    @madsmtm
    madsmtm committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    48d3aa1 View commit details
    Browse the repository at this point in the history

  3. Don't mention block_signature_string, it's not public

    @madsmtm
    madsmtm committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2b47bf6 View commit details
    Browse the repository at this point in the history

  4. All Encoding::size to use alignment in the future

    @madsmtm
    madsmtm committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    23fceed View commit details
    Browse the repository at this point in the history

  5. Make with_encoding safe 

    The `ManualBlockEncoding` is already `unsafe`, and contains the block's
arguments and return type, so we can use that to mark the actual method
that the user calls safe.
    @madsmtm
    madsmtm committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0acb681 View commit details
    Browse the repository at this point in the history

  6. Add changelog entries

    @madsmtm
    madsmtm committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    00173dd View commit details
    Browse the repository at this point in the history

  7. Fix test on Aarch64

    @madsmtm
    madsmtm committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b132646 View commit details
    Browse the repository at this point in the history