Skip to content

Commit

Permalink
## 3.0.0
Browse files Browse the repository at this point in the history
  * Ruby 2.5 のサポート廃止
  * CarrierWave v3 のサポート
  • Loading branch information
y-matsuda-maedadev committed Jan 19, 2024
1 parent b33f14a commit e20bdb2
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 6 deletions.
1 change: 1 addition & 0 deletions .ruby-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2.7.8
18 changes: 18 additions & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
## 3.0.0
* Ruby 2.5 のサポート廃止
* CarrierWave v3 のサポート
ファイルの保存処理が after_commit から after_save になります。
https://github.com/carrierwaveuploader/carrierwave/blob/master/CHANGELOG.md
```
[BREAKING CHANGE] Change to store files on after_save hook instead of after_commit, with performing cleanup when transaction is rolled back (@fsateler #2546)
```
CarrierWave v2 では after_commit でファイルを保存していたので、ActiveRecrodが保存されてもその後のファイル保存中にネットワークエラーなどがあるとファイルは存在しない、といったことが発生してました。
CarrierWave v3 では after_save でファイルを保存するので、ファイルの保存でエラーになると、ActiveRecordの保存もロールバックされます。
参考:
* v3 で after_save に戻した: https://github.com/carrierwaveuploader/carrierwave/pull/2546
* v2 の時に after_commit になった: https://github.com/carrierwaveuploader/carrierwave/pull/2209
--------------------------------------------------------------------------------
## 2.3.7
* Bizside::CronValidator
** バリデーションを強化
Expand Down
6 changes: 3 additions & 3 deletions bizside.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ Gem::Specification.new do |s|
Dir['rails/**/*'] +
Dir['validations/**/*']

s.required_ruby_version = '>= 2.5.0'
s.required_ruby_version = '>= 2.7.0'

s.add_runtime_dependency 'activesupport', '>= 5.0.0', '< 7.0.0'
s.add_runtime_dependency 'aws-sdk-s3', '~> 1.94'
s.add_runtime_dependency 'capistrano', '< 3.0.0'
s.add_runtime_dependency 'carrierwave', '~> 2.2'
s.add_runtime_dependency 'carrierwave', '>= 2.2.0', '< 4.0.0'
s.add_runtime_dependency 'carrierwave-magic', '~> 0.0.4'
s.add_runtime_dependency 'fog-aws', '~> 3.0'
s.add_runtime_dependency 'faraday', '>= 0.12', '< 2.0.0'
Expand All @@ -33,7 +33,7 @@ Gem::Specification.new do |s|
s.add_runtime_dependency 'rake', '>= 12.3', '< 14.0'

s.add_development_dependency 'RedCloth', '~> 4.2'
s.add_development_dependency 'capybara', '~> 3.0', '< 3.36'
s.add_development_dependency 'capybara', '~> 3.0'
s.add_development_dependency 'cucumber', '~> 7.1'
s.add_development_dependency 'cucumber-rails', '~> 2.5'
s.add_development_dependency 'devise', '>= 3.4.0', '< 5.0.0'
Expand Down
1 change: 1 addition & 0 deletions bizside_test_app/.ruby-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2.7.8
4 changes: 2 additions & 2 deletions bizside_test_app/Gemfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
source 'https://rubygems.org'

rails_version = ENV.fetch('RAILS_VERSION', '5.2.x')
rails_version = ENV.fetch('RAILS_VERSION', '6.1.x')
gem 'rails', "~> #{rails_version}"

gem 'bizside', path: '..'
Expand All @@ -18,7 +18,7 @@ gem 'nokogiri'
gem 'redis', '~> 4.0'
gem 'request-log-analyzer'
gem 'resque'
gem 'resque-scheduler'
gem 'resque-scheduler', '~> 4.8.0'
gem 'rmagick'
gem 'sass-rails', '~> 5.0'
gem 'sqlite3', '>= 1.3', '< 1.6.0'
Expand Down
2 changes: 1 addition & 1 deletion lib/bizside/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Bizside
VERSION = '2.3.7'
VERSION = '3.0.0'
end

0 comments on commit e20bdb2

Please sign in to comment.