Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis support #22

Merged
merged 13 commits into from
Nov 7, 2023
Merged

Redis support #22

merged 13 commits into from
Nov 7, 2023

Conversation

sriniarul
Copy link
Contributor

@sriniarul sriniarul commented Oct 1, 2023 •
edited
Loading

Summary

Added Redis dependency to the chart to support multiple replicas
Standalone scheduler and webserver option added to the chart

Tests

Deployed standalone mode with Redis enabled in the chart as well as external Redis URL - passed
Deployed multiple replicas with Redis enabled in the chart as well as external Redis URL - passed

CC

@wangxiaoyou1993, @dy46, @johnson-mage, @tommydangerous

@arulsrinivaasan-everbee
redis support
8b1c65b 
support redis
standalone scheduler and webserver option
@arulsrinivaasan-everbee
scheduler standalone mode fix
c4b1dbb 
scheduler standalone mode fix
@arulsrinivaasan-everbee
redis service name updated
38c2a04
@arulsrinivaasan-everbee
replica count default set to 1
95eb275 
replica count default set to 1
@wangxiaoyou1993
Copy link
Member

Thank you for creating the PR! We'll review it today.

@sriniarul
Copy link
Contributor Author

Thank you for creating the PR! We'll review it today.

i have added a redis dependency chart, which is missing in the CI test.

@wangxiaoyou1993
Copy link
Member

Hi @sriniarul , I notice the chart-testing still fails.
image
Could you try adding the command to the Dockerfile for chart testing? https://github.com/mage-ai/helm-charts/blob/master/.github/actions/chart-testing/Dockerfile

helm repo add bitnami https://charts.bitnami.com/bitnami

@sriniarul
Copy link
Contributor Author

Hi @sriniarul , I notice the chart-testing still fails. image Could you try adding the command to the Dockerfile for chart testing? https://github.com/mage-ai/helm-charts/blob/master/.github/actions/chart-testing/Dockerfile

helm repo add bitnami https://charts.bitnami.com/bitnami

@wangxiaoyou1993
find the PR for the patch
#24 (comment)

@sriniarul
Copy link
Contributor Author

sriniarul commented Oct 29, 2023 •
edited
Loading

Hi @sriniarul , I notice the chart-testing still fails. image Could you try adding the command to the Dockerfile for chart testing? https://github.com/mage-ai/helm-charts/blob/master/.github/actions/chart-testing/Dockerfile

helm repo add bitnami https://charts.bitnami.com/bitnami

@wangxiaoyou1993 find the PR for the patch #24 (comment)

@wangxiaoyou1993 fixed linting issues

wangxiaoyou1993
wangxiaoyou1993 reviewed Nov 6, 2023
View reviewed changes
charts/mageai/values.yaml Outdated Show resolved Hide resolved
charts/mageai/templates/scheduler.yaml Outdated Show resolved Hide resolved
charts/mageai/templates/deployment.yaml Show resolved Hide resolved
@wangxiaoyou1993 wangxiaoyou1993 merged commit ba5d098 into mage-ai:master Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangxiaoyou1993 wangxiaoyou1993 wangxiaoyou1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sriniarul @wangxiaoyou1993 @arulsrinivaasan-everbee