Fix search suggestions #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added additional check to ensure autocomplete suggests only searchable terms --------- Co-authored-by: Ryan Sun <[email protected]>
* added additional check to ensure autocomplete suggests only searchable terms * updated unitest for search suggest fix * added type casting for isSuggestible * reverted suggestible flag and fixed getSuggestFields method * updated suggest contructor params to avoid bic * updated unit test with new dependency productAttributeCollectionFactory for Suggestions * add fieldProvider back to Suggestions constructor --------- Co-authored-by: Ryan Sun <[email protected]>
fballiano
approved these changes
Oct 30, 2024
|
@rhoerr it seems to me the PR is complete, about the checkpoints, is there a README to write? |
I don't think that applies for this one. This is the relevant module readme: https://github.com/mage-os/mageos-magento2/blob/e31c588dd262be976341fd80dfd675f901e3c605/app/code/Magento/Elasticsearch/README.md That checkbox probably almost never applies, actually, except in cases where a core module is being added or completely overhauled. For us, any changes of that nature would be in separate modules and repositories to avoid BC issues. |
|
the I think this is ready to merge |
|
@rhoerr I'd squash this specific one, seems more appropriated to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixes autocomplete search suggestions pulling terms from non-searchable fields.
Cherry-pick of changes from
2.4-developtorelease/1.x.Related Pull Requests
#102
#104
Contribution checklist (*)