Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Branding #21

Merged
merged 13 commits into from
Oct 7, 2023
Merged

Update Branding #21

merged 13 commits into from
Oct 7, 2023

Conversation

pykettk
Copy link
Contributor

@pykettk pykettk commented Dec 14, 2022 •
edited
Loading

Description (*)

Updates the admin footer and logo to Mage-OS branding.

Manual Testing Scenarios (*)

  1. Navigate to the admin login page
  2. Observe that the Magento logo is replaced with the Mage-OS logo
  1. Log into the admin
  2. Observe that the logo has been updated to be the Mage-OS logo
  3. Observe that the footer references Mage-OS
  4. Observe that the copyright notice logo links to the Mage-OS website
  5. Observe that the privacy policy and bug report links navigate to their Mage-OS counterparts

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@pykettk pykettk marked this pull request as ready for review December 14, 2022 00:14
@pykettk pykettk requested a review from a team as a code owner December 14, 2022 00:14
@rhoerr
Copy link
Contributor

rhoerr commented Dec 20, 2022

  1. The copyright notice icon in the footer remains to be updated - I will likely need additional input/guidance on how we want to change that, if at all.

The M logo is Adobe's intellectual property, we won't be able to reuse it at all even if it's in the normal Magento repository (I'm pretty sure). So we'll need to replace or remove that icon in the footer, yes. I lean toward removing it personally -- I'm not sure what that little icon adds.

We'll also need to replace any M favicons in the repository.

  1. Do we want to change the name of the logo file from magento-icon.svg to mageos-icon.svg and update the relevant code to use this new name instead?

For the same reason as above -- yes, I think we need to update the logo filename as well.

Things I see remaining (here or in separate PRs as appropriate):

  • Change or remove the footer M logo
  • Replace any M favicons
  • Change the admin logo filename
  • Change the 'Report an issue' footer URL (and the privacy policy URL?)
  • Change the footer message (in place of copyright) -- maybe to 'Learn more about Mage-OS', or 'Thanks for using Mage-OS', or 'Provided by the Mage-OS Association', or similar.

Thank you!

@pykettk
Copy link
Contributor Author

pykettk commented Dec 30, 2022 •
edited
Loading

Thanks, @rhoerr !

The M logo is Adobe's intellectual property, we won't be able to reuse it at all even if it's in the normal Magento repository (I'm pretty sure). So we'll need to replace or remove that icon in the footer, yes. I lean toward removing it personally -- I'm not sure what that little icon adds.

I'll do that as part of this PR 👍

We'll also need to replace any M favicons in the repository.

I'll replace any of the other admin area icons and open a separate PR for the remaining ones.

I think we need to update the logo filename as well.

Not a problem, I'll make the necessary changes soon - I should have some time in the next couple of days or so 🙂

Change the 'Report an issue' footer URL (and the privacy policy URL?)

Happy to do that too!

Change the footer message (in place of copyright) -- maybe to 'Learn more about Mage-OS', or 'Thanks for using Mage-OS', or 'Provided by the Mage-OS Association', or similar.

I like this idea too. I think a thanks and a link to the website would be nice 🙂 Something like "Thank you for choosing Mage-OS. Learn more about Mage-OS." perhaps?

@rhoerr
Copy link
Contributor

rhoerr commented Jan 2, 2023

I like this idea too. I think a thanks and a link to the website would be nice 🙂 Something like "Thank you for choosing Mage-OS. Learn more about Mage-OS." perhaps?

That sounds great! Thanks.

@pykettk
Update Copyright Notice
4671fe8 
+ Remove Magento icon
+ Update copyright notice wording
@pykettk
Copy link
Contributor Author

pykettk commented Jan 22, 2023

  1. Admin footer logo removed
  2. Admin logo filenames changed (including login page)
  3. Privacy policy and bug report links updated to Mage-OS equivalents
  4. Footer messaged changes

Admin Login Page

admin-login-page

Admin Dashboard

The bottom half of the page looks slightly weird thanks to Chrome's full page screenshot tool.

admin-dashboard

@pykettk
Refactor Admin Header Template
e8b599f 
+ Escape unescaped outputs
+ Adhere to line length limit
+ Consistent formatting
@pykettk
Update Fallback Logo URL to Mage-OS Logo
e9f2218
@pykettk
Copy link
Contributor Author

pykettk commented Jan 22, 2023

There are a few remaining instances of files pointing to the old Magento logo however these are all static URLs and I could not find a similar URL for the Mage-OS logo as it is an inline SVG on mage-os.org.

old-logo-refs

@pykettk pykettk changed the title Update Admin Branding Update Branding Jan 22, 2023
@rhoerr
Copy link
Contributor

rhoerr commented Sep 2, 2023

Pardon the delay. I installed this on an instance, and it looks great! We're getting closer to a release, which means getting this merged in. 🙂

I found some more branded images:

The favicon is most visible. Favicon can maybe be based on https://mage-os.org/wp-content/uploads/2023/03/cropped-logo-mark-180x180.png

Thank you!

@pykettk
Copy link
Contributor Author

pykettk commented Sep 2, 2023 •
edited
Loading

Thanks, @rhoerr 🙂 I'll make some time to look at this soon - likely next weekend or during the week following that 🤞

This was referenced Sep 8, 2023
Closed
Merged
@rhoerr rhoerr mentioned this pull request Sep 23, 2023
Merged
5 tasks
@rhoerr
Copy link
Contributor

rhoerr commented Oct 2, 2023

Hi @pykettk, were you able to look at this? If you can't make time, that's okay. We're looking at merging within a matter of days.

@pykettk
Copy link
Contributor Author

pykettk commented Oct 2, 2023 •
edited
Loading

@rhoerr Not yet - I had to push this down my list 🙁 I'll make time to look at this tomorrow for sure though - likely to be from around 4PM/5PM BST🙂

@pykettk
Copy link
Contributor Author

pykettk commented Oct 3, 2023

@rhoerr I've changed the images you highlighted above. I tried to stick relatively close to the Magento "style" for things like size and orientation etc.

@rhoerr
Copy link
Contributor

rhoerr commented Oct 3, 2023

Awesome, thank you @pykettk! All looks good to me.

rhoerr
rhoerr previously approved these changes Oct 3, 2023
View reviewed changes
@pykettk pykettk force-pushed the admin-branding branch 2 times, most recently from dba670a to c08b48b Compare October 6, 2023 13:34
@pykettk pykettk requested a review from rhoerr October 6, 2023 14:56
@Vinai Vinai merged commit 4310d62 into mage-os:2.4-develop Oct 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhoerr rhoerr rhoerr approved these changes

@Vinai Vinai Vinai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pykettk @rhoerr @Vinai