Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NX based Unit Testing #31

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

adamzero1
Copy link
Contributor

Description (*)

  • Leveraging NX to run only effected unit tests
  • Adding a supported-services.json to ensure that tests run for all supported versions of PHP

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@adamzero1 adamzero1 requested a review from a team as a code owner August 1, 2023 09:28
@adamzero1 adamzero1 mentioned this pull request Aug 1, 2023
@adamzero1
Copy link
Contributor Author

These two pull requests give examples of it in action:
#30
#29

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am hesitant to add a file to the root directory. Would it be an idea to add it to .github/workflows/ instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it got approved in a previous meeting (quite a while ago now).
Ideally I'd like it to go in root, just so it can be part of a release. This way there would be a way to programatically determine what services a specific version of mage-os supports / has been tested.
I was also intending to leverage this file with the integration tests.
What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, why not. No hard feelings here :)

@Vinai Vinai merged commit f773b89 into mage-os:2.4-develop Aug 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants