Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test run PHPCS baseline #34

Closed
wants to merge 20 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/coding-standard-baseline.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: Coding Standard With Baseline
on:
pull_request:

permissions:
contents: read
jobs:
coding-standard:
runs-on: ubuntu-latest
steps:
- name: Run Coding Standard Baseline
uses: Tjitse-E/github-actions/coding-standard-baseline@fix/phpcs-baseline-action-v2
3 changes: 3 additions & 0 deletions app/code/Magento/Backend/i18n/en_US.csv
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,10 @@ password,password
"Reload Data","Reload Data"
"Browse Files...","Browse Files..."
Magento,Magento
"Mage-OS","Mage-OS"
"Copyright © %1 Magento Commerce Inc. All rights reserved.","Copyright © %1 Magento Commerce Inc. All rights reserved."
"Thank you for choosing Mage-OS.","Thank you for choosing Mage-OS."
"Learn more about Mage-OS.","Learn more about Mage-OS."
"ver. %1","ver. %1"
"Magento Admin Panel","Magento Admin Panel"
"Account Setting","Account Setting"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<move element="logo" destination="login.header" before="-"/>
<referenceBlock name="logo">
<arguments>
<argument name="logo_image_src" xsi:type="string">images/magento-logo.svg</argument>
<argument name="logo_image_src" xsi:type="string">images/mage-os-logo.svg</argument>
</arguments>
</referenceBlock>

Expand Down
6 changes: 3 additions & 3 deletions app/code/Magento/Backend/view/adminhtml/layout/default.xml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<arguments>
<argument name="show_part" xsi:type="string">logo</argument>
<argument name="edition" translate="true" xsi:type="string">Community Edition</argument>
<argument name="logo_image_src" xsi:type="string">images/magento-icon.svg</argument>
<argument name="logo_image_src" xsi:type="string">images/mage-os-icon.svg</argument>
</arguments>
</block>
<block class="Magento\Backend\Block\GlobalSearch" name="global.search" as="search" after="logo" aclResource="Magento_Backend::global_search"/>
Expand Down Expand Up @@ -63,12 +63,12 @@
<block class="Magento\Backend\Block\Page\Footer" name="version" as="version" />
<block class="Magento\Framework\View\Element\Template" name="privacyPolicy" as="privacyPolicy" template="Magento_Backend::page/privacyPolicy.phtml">
<arguments>
<argument name="privacypolicy_url" xsi:type="string">https://www.adobe.com/privacy/policy.html</argument>
<argument name="privacypolicy_url" xsi:type="string">https://mage-os.org/privacy-policy</argument>
</arguments>
</block>
<block class="Magento\Framework\View\Element\Template" name="report" as="report" template="Magento_Backend::page/report.phtml">
<arguments>
<argument name="bugreport_url" xsi:type="string">https://github.com/magento/magento2/issues</argument>
<argument name="bugreport_url" xsi:type="string">https://github.com/mage-os/mageos-magento2/issues</argument>
</arguments>
</block>
</container>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

use Magento\Backend\Block\Page\Copyright;
use Magento\Framework\Escaper;

/** @var Escaper $escaper */
/** @var Copyright $block */
?>
<a class="link-copyright" href="http://magento.com" target="_blank" title="<?= $block->escapeHtmlAttr(__('Magento')) ?>"></a>
<?= $block->escapeHtml(__('Copyright &copy; %1 Magento Commerce Inc. All rights reserved.', date('Y'))) ?>
<?= $escaper->escapeHtml(__('Thank you for choosing Mage-OS.')); ?>
<a class="link-copyright"
href="https://mage-os.org/"
target="_blank"
title="<?= $escaper->escapeHtmlAttr(__('Mage-OS')); ?>">
<?= $escaper->escapeHtml(__('Learn more about Mage-OS.')); ?>
</a>
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,14 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

use Magento\Backend\Block\Page\Footer;
use Magento\Framework\Escaper;

/** @var Escaper $escaper */
/** @var Footer $block */
?>
<p class="magento-version">
<strong><?= $block->escapeHtml(__('Magento')) ?></strong>
<?= $block->escapeHtml(__('ver. %1', $block->getMagentoVersion())) ?>
<strong><?= $escaper->escapeHtml(__('Mage-OS')); ?></strong>
<?= $escaper->escapeHtml(__('ver. %1', $block->getMagentoVersion())); ?>
</p>
110 changes: 61 additions & 49 deletions app/code/Magento/Backend/view/adminhtml/templates/page/header.phtml
Original file line number Diff line number Diff line change
Expand Up @@ -3,62 +3,74 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
declare(strict_types=1);

/** @var $block \Magento\Backend\Block\Page\Header */
use Magento\Backend\Block\Page\Header;
use Magento\Framework\Escaper;

/** @var Escaper $escaper */
/** @var Header $block */
$part = $block->getShowPart();
?>
<?php if ($part === 'logo') : ?>
<?php $edition = $block->hasEdition() ? 'data-edition="' . $block->escapeHtml($block->getEdition()) . '"' : ''; ?>
<?php $logoSrc = ($block->hasLogoImageSrc()) ? $block->escapeHtml($block->getLogoImageSrc()) : 'images/magento-logo.svg' ?>
<a
href="<?= $block->escapeUrl($block->getHomeLink()) ?>"
<?= /* @noEscape */ $edition ?>
class="logo">
<img class="logo-img" src="<?= /* @noEscape */ $block->getViewFileUrl($logoSrc) ?>"
alt="<?= $block->escapeHtml(__('Magento Admin Panel')) ?>" title="<?= $block->escapeHtml(__('Magento Admin Panel')) ?>"/>
</a>
<?php elseif ($part === 'user') : ?>
<div class="admin-user admin__action-dropdown-wrap">
<a
href="<?= /* @noEscape */ $block->getUrl('adminhtml/system_account/index') ?>"
class="admin__action-dropdown"
title="<?= $block->escapeHtml(__('My Account')) ?>"
data-mage-init='{"dropdown":{}}'
data-toggle="dropdown">
<span class="admin__action-dropdown-text">
<span class="admin-user-account-text"><?= $block->escapeHtml($block->getUser()->getUserName()) ?></span>
<?php $edition = $block->hasEdition()
? 'data-edition="' . $escaper->escapeHtml($block->getEdition()) . '"'
: ''; ?>
<?php $logoSrc = $block->hasLogoImageSrc()
? $escaper->escapeHtml($block->getLogoImageSrc())
: 'images/mage-os-logo.svg'; ?>
<a href="<?= $escaper->escapeUrl($block->getHomeLink()); ?>"
<?= /* @noEscape */ $edition; ?>
class="logo">
<img class="logo-img"
src="<?= $escaper->escapeUrl($block->getViewFileUrl($logoSrc)); ?>"
alt="<?= $escaper->escapeHtml(__('Magento Admin Panel')); ?>"
title="<?= $escaper->escapeHtml(__('Magento Admin Panel')); ?>"/>
</a>
<?php elseif ($part === 'user'): ?>
<div class="admin-user admin__action-dropdown-wrap">
<a href="<?= $escaper->escapeUrl($block->getUrl('adminhtml/system_account/index')); ?>"
class="admin__action-dropdown"
title="<?= $escaper->escapeHtmlAttr(__('My Account')); ?>"
data-mage-init='{"dropdown":{}}'
data-toggle="dropdown">
<span class="admin__action-dropdown-text">
<span class="admin-user-account-text">
<?= $escaper->escapeHtml($block->getUser()->getUserName()); ?>
</span>
</a>
<ul class="admin__action-dropdown-menu">
<?php if ($block->getAuthorization()->isAllowed('Magento_Backend::myaccount')) : ?>
<li>
<a
href="<?= /* @noEscape */ $block->getUrl('adminhtml/system_account/index') ?>"
<?= /* @noEscape */ $block->getUiId('user', 'account', 'settings') ?>
title="<?= $block->escapeHtml(__('Account Setting')) ?>">
<?= $block->escapeHtml(__('Account Setting')) ?> (<span class="admin-user-name"><?= $block->escapeHtml($block->getUser()->getUserName()) ?></span>)
</a>
</li>
<?php endif; ?>
<li>
<a
href="<?= /* @noEscape */ $block->getBaseUrl() ?>"
title="<?= $block->escapeHtml(__('Customer View')) ?>"
target="_blank" class="store-front">
<?= $block->escapeHtml(__('Customer View')) ?>
</a>
</li>
</span>
</a>
<ul class="admin__action-dropdown-menu">
<?php if ($block->getAuthorization()->isAllowed('Magento_Backend::myaccount')): ?>
<li>
<a
href="<?= /* @noEscape */ $block->getLogoutLink() ?>"
class="account-signout"
title="<?= $block->escapeHtml(__('Sign Out')) ?>">
<?= $block->escapeHtml(__('Sign Out')) ?>
<a href="<?= $escaper->escapeUrl($block->getUrl('adminhtml/system_account/index')); ?>"
<?= /* @noEscape */ $block->getUiId('user', 'account', 'settings'); ?>
title="<?= $escaper->escapeHtml(__('Account Setting')); ?>">
<?= $escaper->escapeHtml(__('Account Setting')); ?>
(<span class="admin-user-name">
<?= $escaper->escapeHtml($block->getUser()->getUserName()); ?>
</span>)
</a>
</li>
</ul>
</div>
<?php endif; ?>

<?php elseif ($part === 'other') : ?>
<?= $block->getChildHtml() ?>
<li>
<a href="<?= $escaper->escapeUrl($block->getBaseUrl()); ?>"
title="<?= $escaper->escapeHtml(__('Customer View')); ?>"
target="_blank"
class="store-front">
<?= $escaper->escapeHtml(__('Customer View')); ?>
</a>
</li>
<li>
<a href="<?= $escaper->escapeUrl($block->getLogoutLink()); ?>"
class="account-signout"
title="<?= $escaper->escapeHtml(__('Sign Out')); ?>">
<?= $escaper->escapeHtml(__('Sign Out')); ?>
</a>
</li>
</ul>
</div>
<?php elseif ($part === 'other'): ?>
<?= $block->getChildHtml(); ?>
<?php endif; ?>
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @var \Magento\Framework\View\Element\Template $block
* @var \Magento\Framework\Escaper $escaper
*/
$viewFileUrl = $block->getViewFileUrl('Magento_LoginAsCustomerFrontendUi::images/magento-icon.svg');
$viewFileUrl = $block->getViewFileUrl('Magento_LoginAsCustomerFrontendUi::images/mage-os-icon.svg');
?>
<?php if ($block->getConfig()->isEnabled()): ?>
<div class="lac-notification-sticky"
Expand All @@ -17,7 +17,9 @@ $viewFileUrl = $block->getViewFileUrl('Magento_LoginAsCustomerFrontendUi::images
<div class="lac-notification clearfix" data-bind="visible: isVisible" style="display: none">
<div class="top-container">
<div class="lac-notification-icon wrapper">
<img class="logo-img" src="<?= $escaper->escapeUrl($viewFileUrl) ?>" alt="Magento" />
<img class="logo-img"
src="<?= $escaper->escapeUrl($viewFileUrl) ?>"
alt="<?= $escaper->escapeHtmlAttr(__('Mage-OS')); ?>"/>
</div>
<div class="lac-notification-text wrapper">
<span data-bind="html: notificationText"></span>
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@

// Copyright
.copyright {
display: flex;
flex-direction: column;
margin-bottom: -.2rem;
position: relative;
text-align: left;
Expand All @@ -67,26 +69,7 @@
vertical-align: top;

&:hover {
&:before {
color: lighten(@color-light-phoenix, 10%);
}
}

&:before {
&:extend(.abs-icon all);
.transition(color);
color: @primary__color;
content: @icon-logo__content;
display: block;
font-size: 2.5rem;
position: relative;
top: -.2rem;
}

&:active {
&:before {
.scale();
}
color: lighten(@color-light-phoenix, 10%);
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
@menu-logo__outer-size: @menu-logo__padding-top + @menu-logo-img__height + @menu-logo__padding-bottom;
@menu-logo__padding-top: 1.7rem;
@menu-logo-img__height: 4.1rem;
@menu-logo-img__width: 3.5rem;
@menu-logo-img__width: 6.5rem;

@menu-item__color: @color-gray65-lighten;
@menu-item__font-size: 1rem;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@
@icon-upgrade__content: '\e614';
@icon-notification-02__content: '\e607';
@icon-product__content: '\e608';
@icon-logo__content: '\e606';
@icon-account__content: '\e600';
@icon-arrowdown__content: '\e601';
@icon-cms__content: '\e602';
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

This file was deleted.

Loading
Loading