Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add phpcs baseline workflow and remove standard phpcs workflow #35

Merged

Conversation

Tjitse-E
Copy link
Contributor

Description (*)

In last weeks technical meeting it was decided to remove the current phpcs workflows, in favour of the phpcs baseline workflow (that only checks if new PHPcs warnings/errors are added by a PR).

Related Pull Requests

Closes #32

Fixed Issues (if relevant)

Fixes: #32 (comment)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@sprankhub sprankhub merged commit 85155c0 into mage-os:2.4-develop Sep 18, 2023
5 checks passed
@Tjitse-E Tjitse-E deleted the feature/activate-baseline-phpcs branch September 18, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants