Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix autochanging stock for new configurable product #88

Closed
wants to merge 1 commit into from
Closed

Draft: Fix autochanging stock for new configurable product #88

wants to merge 1 commit into from

Conversation

vpodorozh
Copy link
Contributor

@vpodorozh vpodorozh commented Feb 20, 2024

Description

Introduce configurable product stock status assement and update based on it's child products. Required while creation of configurable product - as all checks realted to autoset of stock status are executed first on simple product, then on configurable while its creation. This leads to not calling processStockForParent method on configurable product - but it should, to set correct stock status for configurable based on child products.

Fixed Issues

#84

introduce configurable product stock status assement and update based on it\'s child products. Required while creation of configurable product - as all checks realted to autoset of stock status are executed first on simple product, then on configurable while its creation. This leads to not calling  method on configurable product - but it should, to set correct stock status for configurable.
@vpodorozh vpodorozh requested a review from a team as a code owner February 20, 2024 07:44
@vpodorozh vpodorozh changed the title mage-os/mageos-magento2#84 Fix autochanging stock for new configurable product Feb 20, 2024
@vpodorozh
Copy link
Contributor Author

vpodorozh commented Feb 20, 2024

@Vinai - I would like to discuss these changes with you.
I've executed full list of integration tests with those changes and I actually see new problems caused by this fix.

  1. The tests it meant to fix had not state in time when they were green - at least in 2.4-develop branch.
  2. Test is covering edge case when configurable product is created with simple that is out of stock - and expects to have configurable product stock item be also out of stock. However, this is not how the stock status of configurable product is checked and used across magento - so I doubt the need of this test.
  3. debugging and handling this took me a lot of time and further investigation would take even more I'm afraid
  4. as mentioned in point 1 - it used to work like this always and everyone is fine with this behaviour.

Based on those factors I would suggest this about skipping current failed test instead of spending hours fixing it.

@vpodorozh vpodorozh changed the title Fix autochanging stock for new configurable product WIP: Fix autochanging stock for new configurable product Feb 20, 2024
@vpodorozh vpodorozh changed the title WIP: Fix autochanging stock for new configurable product Draft: Fix autochanging stock for new configurable product Feb 20, 2024
@vpodorozh vpodorozh marked this pull request as draft February 20, 2024 15:49
@vpodorozh vpodorozh closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant