#79 - add shutdown functions wrapper to make sure TestModules will be… #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removed ONLY after all other shut down fucntions be executed.
… removed ONLY after all other shut down fucntions be executed.
Vinai
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added Wrapper for registering the deleteTestModules function on shutdown.
This wrapper makes sure that we are running the deleteTestModules function after ALL other shutdown functions.
It prevents issues with SessionManager
register_shutdown_function([$this, 'writeClose']);- which used to be called AFTER modules removing - and Fatal Error was thrown.Fixed Issues (if relevant)
#79