Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid data-sets for unit tests #95

Merged
merged 9 commits into from
Apr 16, 2024
Merged

Fix invalid data-sets for unit tests #95

merged 9 commits into from
Apr 16, 2024

Conversation

vpodorozh
Copy link
Contributor

@vpodorozh vpodorozh commented Apr 8, 2024

Description (*)

Fix unit tests for these modules:

  • ImportExport
  • Framework\MessageQueue
  • Sales
  • Integration
  • Email

After these changes - unit tests should be failed due to mysterious reasons.

Reasons why tests were failed

XSD schema got changed. But it was not represented in Unit Tests.

@vpodorozh vpodorozh requested a review from a team as a code owner April 8, 2024 18:30
@vpodorozh vpodorozh marked this pull request as draft April 8, 2024 18:30
@vpodorozh vpodorozh changed the title Fix invalid data-sets for catalog unit tests Fix invalid data-sets for unit tests Apr 9, 2024
@vpodorozh vpodorozh marked this pull request as ready for review April 9, 2024 08:54
Copy link
Contributor

@Vinai Vinai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vinai Vinai merged commit e53dbb6 into mage-os:2.4-develop Apr 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants