Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magento\Framework\Filesystem\Driver\Http::isExists - Removed "OK" phrase check #39558

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Magento\Framework\Filesystem\Driver\Http::isExists - Removed "OK" phrase check #39558

wants to merge 1 commit into from

Conversation

ajith107
Copy link

Description (*)

  • Removed the OK phrase from the condition check
  • Updated the Unit test data provider

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes - Magento\Framework\Filesystem\Driver\Http depends on reason phrase OK #39546

Manual testing scenarios (*)

  1. Tested & verified the fix in the local Magento setup

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jan 20, 2025

Hi @ajith107. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ajith107
Copy link
Author

Close & reopen the PR after singing the Adobe CLA

@ajith107 ajith107 closed this Jan 20, 2025
@ajith107 ajith107 reopened this Jan 20, 2025
@ajith107
Copy link
Author

@adobe/open-source-office I have just singed the Adobe CLA. However It's not getting reflected in my PR

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 21, 2025
@ajith107
Copy link
Author

Close & reopen after signing Adobe CLA

@ajith107 ajith107 closed this Jan 23, 2025
@ajith107 ajith107 reopened this Jan 23, 2025
@ajith107
Copy link
Author

@magento run all tests

@ajith107
Copy link
Author

@magento run Static Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees
No one assigned
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review
Projects
Pull Requests Dashboard
Status: Review in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajith107 @ihor-sviziev @engcom-Hotel @magento-ct-gh-projects-svc