Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3154:GraphQL cacheable requests always have Authorization Bearer … #4236

Closed
wants to merge 3 commits into from

Conversation

glo11372
Copy link
Contributor

@glo11372 glo11372 commented Feb 28, 2024

Description

GraphQL cacheable requests always have Authorization Bearer header

Step to Create
1- sign up.in Venia.magento.com or any PWA store
2- login
3- check network tab on any page and search for GraphQL requests which should be cached such as CMSPages
4- check the request header you will not find Authorization Bearer header
5- Varnish will cache that request's response.

Related Issue

Closes # PWA-3154

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Feb 28, 2024

Messages
📖

Associated JIRA tickets: PWA-3154.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 02ae675

@glo11372 glo11372 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Feb 29, 2024
@glo11372
Copy link
Contributor Author

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 29, 2024

Successfully started codebuild job for lighthouse-desktop

@glo11372
Copy link
Contributor Author

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 29, 2024

Successfully started codebuild job for lighthouse-mobile

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Feb 29, 2024

Fails
🚫

node failed.

Log

Error: Error: Cannot find module './.lighthouseci/assertion-results.json'
Require stack:
- dangerfile.lighthouse.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-6d468a14.json

Generated by 🚫 dangerJS against 02ae675

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

Error: Error: Cannot find module './.lighthouseci/assertion-results.json'
Require stack:
- dangerfile.lighthouse.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-0260cf9a.json

Generated by 🚫 dangerJS against 34b2d44

@glo11372
Copy link
Contributor Author

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 29, 2024

Successfully started codebuild job for lighthouse-desktop

@glo11372
Copy link
Contributor Author

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 29, 2024

Successfully started codebuild job for lighthouse-desktop

@glo11372 glo11372 closed this Mar 4, 2024
@glo11372 glo11372 deleted the PWA-3154-T1 branch March 4, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Don't Merge pkg:peregrine version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants