Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible without MSI modules #6

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from

Conversation

zeel1012
Copy link

Preconditions
Tested on this versions:

  1. Magento 2.4.6-p4
  2. Magento 2.4.7
  3. Module-version 1.3.0

Description
When the MSI module is disabled, and we set the cart price rule (add a gift) without a specific coupon code, we can't add a product to the cart when the subtotal is more than the rule price. If we set a rule with a specific coupon code, we are unable to apply that coupon code, and it gives an error (see screenshot 3)

Steps to Reproduce

  1. Install a clean Magento shop with sampledata.
  2. Installed the Magesuite-FreeGift module.
  3. navigate to Marketing -> Cart Price Rules. Create a new cart rule, and within the Actions tab, set the options as depicted in the screenshot below(screeenshot 1)
    image
  4. Now, go to Catalog -> Products and create a product with a price greater than 100, as depicted in the screenshot below(Screenshot-2)
    image
  5. Now, go to the the frontend and add that product into the cart and apply that cart price rule.(screeenshot 3)
    image
    6.observe.

Actual Result
The cart price rule should not be applied without the MSI module.

Expected Result
The cart price rule should be applied with or without the MSI module

Reason
This issue occurs when the MSI module is disabled. At that time, it is not compatible with the functionality in the module. They use the MSI class, and when that module is disabled, it should not run and creates an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant