Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Options.php #1

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Update Options.php #1

wants to merge 1 commit into from

Conversation

kkkonrad
Copy link

No description provided.

@diwipl
Copy link
Contributor

diwipl commented Apr 23, 2020

Hi,
Thank you for contributing to MageSuite.
Unfortunately we will not accept this pull request, it is our idea to have whole label passed to translation function. That way we can using only CSV translation files change "Price - Descending" to for example "From the lowest price" or "Lowest price first". Without having attribute label in it, it would be impossible.

@kkkonrad
Copy link
Author

ok but there is problem with custom attribute translation, where user can translate attribute name from admin panel but not - Descending or - Ascending part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkkonrad @diwipl