Skip to content

Commit

Permalink
Update targetSDK to 35 and reenable linting on CI (#23)
Browse files Browse the repository at this point in the history
* Reenable Linting on CI

* Annotate PR with linter errors and warnings

* Update SDKs targetSdk to 33

* Update SDKs targetSdk to 35

* Adding changeset

* Prevent toolbar from being drawn underneath the status bar
  • Loading branch information
stigi authored Oct 9, 2024
1 parent d248dc9 commit 54f5bc5
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 4 deletions.
7 changes: 7 additions & 0 deletions .changeset/ninety-geckos-sneeze.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"magicbell-android": minor
---

Updated the `targetSDK` of both, `sdk` and `sdk-compose` to version `35`

Please follow the _Android SDK Upgrade Assistant_ for upgrading your own apps.
10 changes: 9 additions & 1 deletion .github/workflows/gradle-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
run: echo $DATA | base64 -di > ./example/google-services.json

- name: Build with Gradle Wrapper
run: ./gradlew build -x lint
run: ./gradlew build

- name: Test with Gradle Wrapper
run: ./gradlew test
Expand All @@ -41,3 +41,11 @@ jobs:
if: success() || failure() # always run even if the previous step fails
with:
report_paths: '**/build/test-results/test*/TEST-*.xml'

- name: Publish Lint Report
uses: yutailang0119/action-android-lint@v4
if: success() || failure() # always run even if the previous step fails
with:
report-path: '**/build/reports/lint-results-*.xml'
ignore-warnings: false
continue-on-error: false # If annotations contain error of severity, action-android-lint exit 1.
2 changes: 1 addition & 1 deletion example/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ android {
defaultConfig {
applicationId "com.magicbell.example"
minSdk 23
targetSdk 34
targetSdk 35
versionCode 1
versionName "1.0"

Expand Down
1 change: 1 addition & 0 deletions example/src/main/res/layout/activity_main.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:fitsSystemWindows="true"
tools:context=".MainActivity">

<com.google.android.material.appbar.AppBarLayout
Expand Down
2 changes: 1 addition & 1 deletion sdk-compose/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ android {

defaultConfig {
minSdk 23
targetSdk 31
targetSdk 35

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles "consumer-rules.pro"
Expand Down
2 changes: 1 addition & 1 deletion sdk/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ android {

defaultConfig {
minSdk 23
targetSdk 31
targetSdk 35

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles "consumer-rules.pro"
Expand Down

0 comments on commit 54f5bc5

Please sign in to comment.