Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a new highlighter component #543

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Pratiyankkumar
Copy link

Added a new Highlighter component which highlights the text as it were highlighted by a human .
Additional features include:

  1. Colour of highlighting : We can provide the colour of highlighting as a prop.
  2. Action of highlighter: We can provide the action of highlighter as a prop , which can be a circle or highlighter.

Preview shown in the image :
Screenshot 2025-02-11 203134

Copy link

vercel bot commented Feb 11, 2025

@Pratiyankkumar is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@Pratiyankkumar
Copy link
Author

@dillionverma Please take a look at this.

@Pratiyankkumar
Copy link
Author

@dillionverma Appreciate you taking a look! 👀 Let me know if it's good to merge.

@dillionverma
Copy link
Collaborator

Great component idea, I could see it being useful for a lot of cases.

However, I think the PR in it's current state feels incomplete.

Some points to improve:

  1. Expose access to all underlying props https://github.com/rough-stuff/rough-notation. Looks like there are more annotation types but this PR limits it to only 2. There are also several other useful props which are hidden.
  2. Give more demo examples

@Pratiyankkumar
Copy link
Author

ok will do that, thanks for pointing out

@Pratiyankkumar
Copy link
Author

Pratiyankkumar commented Feb 20, 2025

Great component idea, I could see it being useful for a lot of cases.

However, I think the PR in it's current state feels incomplete.

Some points to improve:

  1. Expose access to all underlying props https://github.com/rough-stuff/rough-notation. Looks like there are more annotation types but this PR limits it to only 2. There are also several other useful props which are hidden.
  2. Give more demo examples

@dillionverma
Added more annotations ✅
Added other useful props to give full access of the component to the user ✅
Given more demo examples ✅
here are the changes :

Screen.Recording.2025-02-20.142052.mp4

@Pratiyankkumar
Copy link
Author

@dillionverma Please tell me if its good to merge or something else is remaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants