Added length parameter to checkbox and list #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticdev
requested changes
Dec 17, 2021
| if self.MAX_OPTIONS_DISPLAYED_AT_ONCE % 2 == 0: | ||
| ending_milestone = max(len(choices) - self.half_options, self.half_options + 1) | ||
| else: | ||
| ending_milestone = max(len(choices) - self.half_options, self.half_options) |
There was a problem hiding this comment.
Since you introduces a new code branch here, would be nice to have a test case when self.MAX_OPTIONS_DISPLAYED_AT_ONCE is odd.
There was a problem hiding this comment.
Sorry im not sure what you mean?
There was a problem hiding this comment.
@domwhewell this IF statement is new on the code, so we should have one test that goes to the IF and on that goes to ELSE to maintain the code coverage of test.
|
Thanks a lot @domwhewell. I checked the code, looks good and I made some comments also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same way @tmsteen did on an older version of the code I have re-added their length parameter to lists and checkboxes in the latest version of the code.
Again to address #80