Force quopri to use CRLF for soft line breaks #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Working on fixing tests... |
mhahnenberg
force-pushed
the
fix-long-quoted-printable-crlf
branch
4 times, most recently
from
77d3718 to
5b3f37b
Compare
quopri tries to automatically detect which type of line ending it should use for soft line breaks which can lead it to making the wrong decision where it tries to use =LF rather than =CRLF. This diff fixes this by prepending a CRLF when encoding a part's body to force quopri to use CRLF and then removes that prefix afterwards.
mhahnenberg
force-pushed
the
fix-long-quoted-printable-crlf
branch
from
5b3f37b to
d93f6bc
Compare
horkhe
reviewed
Jun 1, 2018
| @@ -631,7 +631,9 @@ def _encode_charset(preferred_charset, text): | |||
| def _encode_transfer_encoding(encoding, body): | |||
| if six.PY3: | |||
| if encoding == 'quoted-printable': | |||
| body = b''.join([b'\r\n', body]) | |||
There was a problem hiding this comment.
I would rather make it as simple as body = b'\r\n' + body
horkhe
reviewed
Jun 1, 2018
| @@ -647,7 +649,9 @@ def _encode_transfer_encoding(encoding, body): | |||
| return body | |||
|
|
|||
| if encoding == 'quoted-printable': | |||
| return quopri.encodestring(body, quotetabs=False) | |||
| body = '\r\n{}'.format(body) | |||
There was a problem hiding this comment.
Same thing here body = '\r\n' + body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quopri tries to automatically detect which type of line ending it should
use for soft line breaks which can lead it to making the wrong decision
where it tries to use =LF rather than =CRLF. This diff fixes this by
prepending a CRLF when encoding a part's body to force quopri to use
CRLF and then removes that prefix afterwards.