Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UV-278 - Modbus Adapter #1

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

UV-278 - Modbus Adapter #1

wants to merge 19 commits into from

Commits on Aug 17, 2023

  1. inital modbus adapter 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    050a194 View commit details
    Browse the repository at this point in the history

  2. add CI and issue templates 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    677f98f View commit details
    Browse the repository at this point in the history

  3. add http endpoint 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c257738 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. add http server 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    ea65ebe View commit details
    Browse the repository at this point in the history

  2. add docker 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    3375514 View commit details
    Browse the repository at this point in the history

  3. add docker 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e0173fc View commit details
    Browse the repository at this point in the history

  4. add examples 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    20e22b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. add stop options 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6a8b15e View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Refactor modbus adapter to use rpc 

    Refactor the modbus adapter codebase by removing unnecessary imports and unused constants.

Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e2180d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Fix Makefile test command and remove unnecessary proto generation 

    The Makefile test command was modified to remove the "-mod=vendor" flag and the proto generation commands were removed as they are unnecessary.

This commit fixes the Makefile test command and removes unnecessary proto generation commands.

Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    16e719d View commit details
    Browse the repository at this point in the history

  2. Fix logger output in modbus service 

    The logger output in the modbus service was not being properly formatted. This commit fixes the issue by using the logger.Info function to print the modbus service listening information.

- Update logger output in modbus service to use logger.Info function
- Fix formatting issue with logger output in modbus service

Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    87b2435 View commit details
    Browse the repository at this point in the history

  3. Fix subscription and publishing bugs 

    This commit fixes bugs related to subscription and publishing in the examples/publish/main.go and examples/subscribe/main.go files. The changes include adding the context package and passing the context to the Publish and Subscribe functions. This ensures that the functions have the necessary context for proper execution.

The bug in the examples/publish/main.go file is fixed by adding the context package and passing the context to the Publish function. Previously, the Publish function was called without a context, which could lead to unexpected behavior.

The bug in the examples/subscribe/main.go file is fixed in a similar manner. The context package is imported, and the context is passed to the Subscribe function. This ensures that the Subscribe function has the necessary context for proper execution.

These changes ensure that the subscription and publishing functionalities work correctly in the examples.

Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    2f2622d View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. remove unused code 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b7108f3 View commit details
    Browse the repository at this point in the history

  2. remove vendor 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5c31616 View commit details
    Browse the repository at this point in the history

  3. remove jaeger 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    17a8df4 View commit details
    Browse the repository at this point in the history

  4. remove unused code 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5326146 View commit details
    Browse the repository at this point in the history

  5. remove internal 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    644d798 View commit details
    Browse the repository at this point in the history

  6. remove unused code 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    24cbd93 View commit details
    Browse the repository at this point in the history

  7. update docs 

    Signed-off-by: SammyOina <[email protected]>
    @SammyOina
    SammyOina committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c4e2107 View commit details
    Browse the repository at this point in the history