Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add devices dialog in editor #1765

Merged
merged 24 commits into from
Feb 15, 2024

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Feb 2, 2024

Description

This PR adds a popup dialog for searching CAN, Serial, USB or Video devices in the editor.

Related Tickets & Documents

PR in Moonraker to add this feature: Arksine/moonraker#798

Mobile & Desktop Screenshots/Recordings

localhost_8080_config (1)
localhost_8080_config (4)

[optional] Are there any post-deployment tasks we need to perform?

  • Publish the docs page for this feature.

Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
@meteyou meteyou requested review from dw-0 and rackrick February 2, 2024 18:49
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0

Copy link
Contributor

github-actions bot commented Feb 4, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

@meteyou meteyou merged commit b9b793d into mainsail-crew:develop Feb 15, 2024
10 checks passed
@meteyou meteyou deleted the feat/add-devices-dialog branch February 15, 2024 21:33
@ccatlett1984
Copy link

Would it be possible to get a scroll bar in the UI, it is not intuitive if you have multiple MCUs that you have to scroll down to see them.

@meteyou
Copy link
Member Author

meteyou commented Feb 17, 2024

@ccatlett1984 there is already a scrollbar in this dialog...

@ccatlett1984
Copy link

ccatlett1984 commented Feb 17, 2024 via email

@dw-0
Copy link
Member

dw-0 commented Feb 17, 2024

I'll have to try another theme, I'll attach screenshots.

If you use a theme other than the Mainsail standard themes, you are more or less on your own, or on the creator of the theme. During development, we really can't take into account that custom themes don't break. Likewise, we cannot guarantee that features will always be displayed correctly with custom themes in addition to the Mainsail standard themes. That is simply impossible.

Apart from that, if I expect a list of something to be displayed and don't see it directly, it's intuitive in my eyes to try scrolling first and see if/what happens. Regardless of whether I see a scrollbar or not. But maybe that's just me...

image

@ccatlett1984
Copy link

ccatlett1984 commented Feb 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants