feat: add conditions to FeatureTracker customer resource #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszmajsak
changed the title
error is handled before
Tests should be easy to read and understand. When each test is self-contained it becomes easier to understand what is being tested and how. This clarity is often more valuable than avoiding duplication.
bartoszmajsak
approved these changes
Dec 22, 2023
bartoszmajsak
changed the title
bartoszmajsak
merged commit 655a27c
into
maistra:service-mesh-integration
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds some more testing for this to the feature test suite.
Image for testing:
quay.io/cgarriso/opendatahub-operator:add-conditionsFuture enhancement to make in future PR will be changing the naming convention for
FeatureTrackerand moving the DSCI name and app namespace into the feature tracker's spec.