Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Rails 8.0, drop support for Rails 5.2 #72

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

mak-dunkelziffer
Copy link
Contributor

@mak-dunkelziffer mak-dunkelziffer commented Dec 19, 2024

This gem has some version switches:

Rails.version.to_i < 3
Rails.version.to_i < 4
Rails.version.to_i < 5

We don't test against any of those versions anymore. We also want to phase out support for older versions of Ruby and Rails. Should I remove them?

Also, should I increase version constraints in the gemspec?

s.add_dependency('memoized', '>=1.0.2')
s.add_dependency('activerecord', '>= 3.2')
s.add_dependency('activesupport', '>= 3.2')
s.add_dependency('railties', '>= 3.2')
s.add_dependency('edge_rider', '>= 0.3.0')

@mak-dunkelziffer mak-dunkelziffer force-pushed the kw/rails-8 branch 7 times, most recently from 300971a to 7c41c25 Compare January 22, 2025 15:51
Copy link
Contributor

@dastra-mak dastra-mak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Gemfile.7-1 Outdated Show resolved Hide resolved
@mak-dunkelziffer mak-dunkelziffer merged commit 1236ca9 into master Jan 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants