Support 2D projections #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supply the required projection as a basis of either xyz, ry, or rz. If the basis is 2D then project the cross section of the plasma onto the provided dimensions.
makeclean
reviewed
Jul 28, 2020
| @@ -24,6 +24,7 @@ const double shafranov_shift = 0.0; //metres | |||
| const std::string name = "parametric_plasma_source"; | |||
| const int number_of_bins = 100; | |||
| const int plasma_type = 1; // 1 is default; //0 = L mode anything else H/A mode | |||
| const std::string basis = "xyz"; // xyz for 3D, ry or rz for 2D | |||
There was a problem hiding this comment.
Makes sense. Linked to an enum now. The enum will need a bit of a tweak when serialising but not major.
|
Apologies for the noisy commits... I'd made a tweak to my WSL install that seemed to screw around with my account. Hopefully fixed now. |
|
Sorry to be a pain is there any chance this PR can be redirect to the new repository https://github.com/open-radiation-sources/parametric-plasma-source |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests to support 2D projections in either the ry or rz planes. This would allow the source to be used for pseudo-2D simulations. Note that the initial direction of the particle has not been modified as the 2D model may or may not be constrained in the third dimension, for example reflective boundaries could be provided to constrain the model, or no boundary could be provided in which case that dimension goes to infinity.