refactor: minor store level changes

[prateekshourya29]

Description

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

• Refactor

  • Renamed teamId to teamspaceId across multiple core store and hook files
  • Updated references and getter methods related to team/teamspace identification
  • Maintained existing logic while updating terminology

• Impact

  • Standardizes terminology for teamspace identification in the application
  • No functional changes to existing behavior

[coderabbitai]

Walkthrough

The pull request involves a systematic renaming of teamId to teamspaceId across multiple TypeScript files in the web core module. This change impacts the routing, issue store, and issue layout hook components, focusing on updating parameter and property names while maintaining the existing logic and functionality. The modifications ensure consistent terminology throughout the frontend codebase, specifically around team-related identifiers.

Changes

File	Change Summary
web/core/hooks/use-issue-layout-store.ts	Replaced teamId with teamspaceId in parameter destructuring and conditional checks
web/core/store/issue/root.store.ts	Updated teamId property to teamspaceId in interface, class, and observable references
web/core/store/router.store.ts	Renamed teamId property and getter method to teamspaceId

Suggested Labels

🌐frontend, 🧹chore

Suggested Reviewers

• sriramveeraghanta
• rahulramesha

Poem

🐰 Hop, hop, through the code we go,
Renaming teamId with a cheerful glow
From team to teamspace, a subtle dance
Refactoring with algorithmic elegance
A rabbit's leap of nomenclature! 🌈

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f2e662 and 2a4b0c4.

📒 Files selected for processing (3)

• web/core/hooks/use-issue-layout-store.ts (2 hunks)
• web/core/store/issue/root.store.ts (4 hunks)
• web/core/store/router.store.ts (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (4)

web/core/hooks/use-issue-layout-store.ts (1)

10-10: LGTM! Consistent renaming of teamId to teamspaceId

The renaming is applied consistently across the file while preserving the existing logic.

Also applies to: 30-30, 32-32

web/core/store/router.store.ts (1)

12-12: LGTM! Complete and consistent renaming in router store

The changes include:

• Interface property update
• Computed property registration
• Updated getter method with proper documentation

Also applies to: 39-39, 74-78

web/core/store/issue/root.store.ts (2)

46-46: LGTM! Thorough renaming in issue root store

All necessary changes have been made consistently:

• Interface property
• Class property initialization
• MobX observable registration
• Autorun condition

Also applies to: 114-114, 181-181, 205-205

---

Line range hint 1-1: Verify complete renaming across the codebase

Let's verify that we haven't missed any instances of teamId that should have been renamed.

✅ Verification successful

Renaming verification completed successfully

The codebase has been thoroughly checked and no remaining instances of teamId were found. The renaming to teamspaceId appears to be complete and consistent across all TypeScript files.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining instances of teamId in TypeScript files
echo "Searching for remaining 'teamId' instances..."
rg --type typescript "teamId" -g '!*.test.ts' -g '!*.spec.ts'

# Search for any inconsistent usage of teamspaceId
echo "Verifying consistent usage of 'teamspaceId'..."
rg --type typescript "teamspaceId"

Length of output: 382

---

Script:

#!/bin/bash
# Search for any remaining instances of old naming patterns
echo "Searching for remaining 'teamId' instances..."
rg "team[_-]?id" -g "*.ts" -g "*.tsx" -g "!*.test.ts" -g "!*.spec.ts" -g "!*.d.ts"

echo -e "\nChecking new 'teamspaceId' usage..."
rg "teamspace[_-]?id" -g "*.ts" -g "*.tsx" -g "!*.test.ts" -g "!*.spec.ts" -g "!*.d.ts"

Length of output: 374

---

Script:

#!/bin/bash
# First verify we can see the files
echo "Checking for TypeScript files..."
find . -type f -name "*.ts" -o -name "*.tsx"

echo -e "\nChecking content of the specific file mentioned in review..."
cat web/core/store/issue/root.store.ts

Length of output: 65732

---

Script:

#!/bin/bash
# Check content of the specific file
echo "Content of web/core/store/issue/root.store.ts:"
cat web/core/store/issue/root.store.ts

echo -e "\nSearching for 'teamId' in all TypeScript files..."
find . -type f \( -name "*.ts" -o -name "*.tsx" \) -not -name "*.test.ts" -not -name "*.spec.ts" -not -name "*.d.ts" -exec grep -l "teamId" {} \;

Length of output: 11466

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.