Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider errors #858

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Provider errors #858

merged 4 commits into from
Mar 26, 2024

Conversation

tyler17
Copy link
Collaborator

@tyler17 tyler17 commented Mar 26, 2024

  • make quorum 1, and add priorities to the providers.
  • fix a couple calls that pass in a rpcUrl instead of a network
  • decrease chunk size to 900
  • run prettier and build

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Mar 26, 2024 1:43am

Copy link

what-the-diff bot commented Mar 26, 2024

PR Summary

  • Updating Calculation in formatDelegationHistoryChart.ts
    The way we were calculating durations has been improved for accuracy. This helps the system better understand and operate on time-sensitive data.

  • Optimization in fetchExecutiveVoteTally.ts
    We reduced the data chunk size from 1000 to 900, which should make data querying faster and more efficient.

  • Enhancing Logic in PollWinningOptionBox.tsx
    The logic around determining the leading option in our polls has been made more robust. This ensures that the most popular options are accurately highlighted.

  • Addition to poll-tags-mapping.json
    Several new elements have been added to this configuration object, which expands our functionality and capabilities around polling.

  • Provider Options Update in getContracts.ts
    The selection of the provider option has been simplified, ensuring that the system uses the best available resource when executing tasks.

  • Return Type Modification in getDefaultProvider.ts
    We switched return types in this function to offer a more versatile solution that allows the system to fall back to alternative providers if the initial provider encounters issues.

  • Network Support Enhancement in getEthersContracts.ts
    We've added support for passing the network information directly. This option leads to better flexibility when choosing providers and handling tasks.

Comment on lines +23 to +28
const provider = new ethers.providers.FallbackProvider([
{ provider: infuraProvider, priority: 2 },
{ provider: alchemyProvider, priority: 1 },
{ provider: pocketProvider, priority: 3 },
{ provider: etherscanProvider, priority: 3 }
], 1); //Quorum of 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, so this will always try alchemy first, and if it is successful then we're good, right?

Copy link

@generatorpoint generatorpoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! I'm seeing the missing exec on the landing page and the MKR support on the executive page.

@adamgoth adamgoth merged commit ff55924 into develop Mar 26, 2024
6 of 7 checks passed
@adamgoth adamgoth deleted the provider-errors branch March 26, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants