Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove spock #895

Open
wants to merge 46 commits into
base: develop
Choose a base branch
from
Open

remove spock #895

wants to merge 46 commits into from

Conversation

tyler17
Copy link
Collaborator

@tyler17 tyler17 commented Jun 7, 2024

Update: This is on hold as it contains updates that aren't related to P1c.

  • Use the new delegate contract factory
  • update delegate queries to use the subgraph instead of spock

@tyler17 tyler17 added the WIP label Jun 7, 2024
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-portal-v2 ❌ Failed (Inspect) Sep 26, 2024 11:29pm

Copy link

what-the-diff bot commented Jun 19, 2024

PR Summary

  • Updated Connection Settings
    The README.md file and several configuration files were updated to connect to the subgraph privately and use a different GraphQL schema URL. New environment variables and links were introduced where necessary.

  • Refactoring Files For Improved Integration With Subgraph
    In order to optimize data acquisition and management, various files were refactored to use subgraph queries and a new structure for handling delegate information.

  • Obsolete Query Removal and Data Type Modification
    Outdated queries were removed and replaced with subgraph queries. Data types were also modified to provide more accurate data representation, for example, changing totalMKRDelegated to a number format.

  • Introduced New Files For Metrics and GraphQL Queries
    A new file has been created specifically for fetching delegation metrics from subgraph. Furthermore, new GraphQL query files have been added to fetch details about delegations, delegation history for multiple delegates, and delegation history of a specific delegator.

  • Updated Network Settings
    The chain ID for TENDERLY in chainID.ts was updated. Other network constant modifications include the addition of TENDERLY subgraph URL and its integration into chain information.

  • Integration with TENDERLY Network
    Replaced getMainnetSdk with getTenderlySdk for the TENDERLY network in getContracts.ts and getReadOnlyContracts.ts.

  • Improved Etherscan Link Generation
    The feature to generate Etherscan links was updated to include a specific URL format for transactions on TENDERLY.

  • Data Type Modification and Suppression of Effects in delegates/index.tsx
    The data type for totalMKRDelegated was modified from string to number. Also, two useEffect hooks related to fetching events and addresses have been temporarily disabled.

@tyler17 tyler17 changed the title New delegate factory remove spock Oct 2, 2024
@DaiFoundation-DevOps
Copy link

DaiFoundation-DevOps commented Oct 8, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ tyler17
❌ adamgoth
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants