Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch cached execs fetches and deletions #966

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Batch cached execs fetches and deletions #966

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b687dfd
Batch cached execs fetches and deletions
hernandoagf Dec 6, 2024
e6b2c9c
Dynamically import lottie
hernandoagf Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 26 additions & 7 deletions modules/cache/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,30 @@ export const cacheDel = (name: string, network: SupportedNetworks, expiryMs?: nu
if (redisCacheEnabled()) {
// if clearing proposals, we need to find all of them first
if (name === 'proposals') {
redis?.keys('*proposals*').then(keys => {
keys.forEach(key => {
logger.debug('cacheDel key: ', key);
redis?.del(key);
});
const deleteProposalKeys = async () => {
let cursor = '0';
do {
const pipeline = (redis as Redis).pipeline();
const [nextCursor, keys] = await (redis as Redis).scan(
cursor,
'MATCH',
'*proposals*',
'COUNT',
'100'
);

if (keys.length > 0) {
logger.debug('cacheDel pattern: *proposals* ', cursor, keys.length);
pipeline.del(...keys);
}

await pipeline.exec();
cursor = nextCursor;
} while (cursor !== '0');
};

deleteProposalKeys().catch(error => {
logger.error('Error deleting proposal keys:', error);
});
} else {
// otherwise just delete the file based on path
Expand Down Expand Up @@ -90,8 +109,8 @@ export const getCacheInfo = async (name: string, network: SupportedNetworks): Pr
// if fetching proposals cache info, there are likely multiple keys cached due to different query params
// we'll return the ttl for first proposals key we find
if (name === executiveProposalsCacheKey) {
const keys = await redis?.keys('*proposals*');
if (keys && keys.length > 0) {
const [, keys] = await (redis as Redis).scan('0', 'MATCH', '*proposals*', 'COUNT', '1');
if (keys.length > 0) {
const ttl = await redis?.ttl(keys[0]);
return ttl;
}
Expand Down
Loading