To main #816
Merged
To main #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix "Cannot read properties of null (reading 'login')" in mips de…
Use Docker and deploy to Staging K8s
eskp
requested review from
cristidas,
sanbotto,
nickkounz,
OleksandrUA,
zdumitru and
jeannettemcd
cristidas
reviewed
May 15, 2024
sanbotto
suggested changes
May 15, 2024
nickkounz
reviewed
May 21, 2024
| - name: Configure AWS credentials | ||
| uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| aws-access-key-id: ${{ secrets.STAGING_AWS_ACCESS_KEY_ID }} |
There was a problem hiding this comment.
You can try to use iam role to deploy since the organisation secret are already available.
# staging
role-to-assume: ${{ secrets.GA_OIDC_EKS_STAGING }}
role-session-name: MIPSSTAGING
aws-region: ${{ env.AWS_REGION }}
# prod
role-to-assume: ${{ secrets.GA_OIDC_EKS_PROD }}
role-session-name: MIPSPROD
aws-region: ${{ env.AWS_REGION }}
also don't forget to add the following for the pipeline
permissions:
id-token: write
contents: read
There was a problem hiding this comment.
Will tackle it as part of the existing ticket in the Backlog
| - name: Deploying Service to Kubernetes with Helm | ||
| id: deploy | ||
| if: ${{ !contains(github.event.head_commit.message , '[skip deploy]') }} | ||
| uses: bitovi/[email protected] |
There was a problem hiding this comment.
1.2.9 is the latest now.
| - name: Configure AWS credentials | ||
| uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| aws-access-key-id: ${{ secrets.PROD_AWS_ACCESS_KEY_ID }} |
| - name: Deploying Service to Kubernetes with Helm | ||
| id: deploy | ||
| if: ${{ !contains(github.event.head_commit.message , '[skip deploy]') }} | ||
| uses: bitovi/[email protected] |
| password: ${{ secrets.SSH_PASS }} | ||
| source: "./backend" | ||
| target: "/var/warehouse/makerdao-mips-develop" | ||
| aws-access-key-id: ${{ secrets.STAGING_AWS_ACCESS_KEY_ID }} |
| password: ${{ secrets.SSH_PASS }} | ||
| source: "./backend" | ||
| target: "/var/warehouse/makerdao-mips" | ||
| aws-access-key-id: ${{ secrets.PROD_AWS_ACCESS_KEY_ID }} |
| - name: Deploying Service to Kubernetes with Helm | ||
| id: deploy | ||
| if: ${{ !contains(github.event.head_commit.message , '[skip deploy]') }} | ||
| uses: bitovi/[email protected] |
| env: | ||
| NODE_ENV: | ||
| type: kv | ||
| value: production |
There was a problem hiding this comment.
As per your Dockerfile, is it supposed to be prod instead of production?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get
mainbranch up to date with the recent changes - deploying to our infra instead of Dspot. Then going forward we'll be able to deploy toprodenv frommainbranch, and tostagingfromdevelop.