-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dewiz x Sidestream x Arby Spell Improvements #12
Conversation
…dded mutability checks
…it uses for itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good from our side and doesn't contain anything we haven't discussed
For complete clarity this is the GovAlpha perspective:
That said, things may change if, at some point, ES is removed from being a core component of the Protocol, and this should be reviewed if and/or when that happens. |
… the next ExecLib release
… payments there) and added checklist items to mainnet reviewer checklist
A suggestion from |
So, there are three sets of things to confirm on the sheet.
The spell sheet itself has not been brought up to date recently. There are a number of rows that are no longer relevant, and the 'When?' column was never updated for the new schedule. We should discuss, and then GovAlpha should do an update pass on it. |
I agree. Let's sync up on this relatively soon so that we can balance overhead / effort expended with transparency. IMO we used to be a little slack on this due to the nature of content coming in late-ish or perhaps just due to the cadence. Having one "official spell comms channel" might be useful when it comes to these kinds of things too (re: you guys knowing where spells are at). Spell crafters determining feasibility of the content is a default yes (IMO) unless the content comes in late, since practically all types of content can be done, it's simply a matter of what gets done when. Pushback on here would rarely happen via sheet, I would assume. So you know, typically (obviously this will likely change with the introduction of subDAOs) all spell content is completed concurrently, with reviews (ideally) covering all included content at once in order to minimize the risk of something sneaking in through a later commit. Happy to explore all the options available here with you and other spell participants at some point in the future; if you have any feedback or recommendations they are always appreciated! |
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
Co-authored-by: amusingaxl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this done!
Hi,
Changes as required from my 2023-05-10 Goerli review.
More to come as necessary.