Baljit's branch for airport_challenge #2495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… confirm completed
I took inspiration from Jordan Manu's README.md to write my README.md
mcsuGH
reviewed
Mar 28, 2022
|
|
||
| describe '# landing' do | ||
|
|
||
| it 'has a Default capcity' do |
lib/airport.rb
Outdated
Comment on lines
22
to
27
| def takeoff(plane) | ||
| fail 'Due to stormy weather no landing allowed' if stormy? | ||
| fail 'Plane is not at the airport' if plane.in_flight? | ||
| @planes.delete(plane) | ||
| 'plane has taken off' | ||
| end |
There was a problem hiding this comment.
takeoff method should change plane's in_flight variable to true
lib/airport.rb
Outdated
Comment on lines
1
to
2
| require 'weather' | ||
| require 'plane' |
There was a problem hiding this comment.
Will do that and resubmit the pull request
|
as per @mcsuGH comments, I have updated require to require_relative in all the files and added updating planes in_flight status takeoff module |
R552-beep
reviewed
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baljit Singh Rakhra
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!