Airport challenge (Erlantz) #2503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmy-lyons
reviewed
Apr 25, 2022
| @@ -0,0 +1,41 @@ | |||
| class Airport | |||
|
|
|||
| DEFAULT_CAPACITY = 1 | |||
There was a problem hiding this comment.
Is this a constant? Could you just set your initialized capacity to 1?
jimmy-lyons
reviewed
Apr 25, 2022
|
|
||
| def take_off(plane) | ||
| fail 'Plane cannot take off on stormy weather' if weather == "stormy" | ||
| fail 'Plane not in this airport' unless plane_in_airport?(plane) |
There was a problem hiding this comment.
This is good. I should have written something similar.
jimmy-lyons
reviewed
Apr 25, 2022
| def weather | ||
| return "stormy" if rand(20) == 1 | ||
| "sunny" | ||
| end |
There was a problem hiding this comment.
I wrote weather as a new class. Yours is more succinct but since the weather is effectively a different entity to airport and plane, I think it should be it's own class.
jimmy-lyons
reviewed
Apr 25, 2022
| allow(subject).to receive(:weather) { "sunny" } | ||
| subject.land(plane) | ||
| expect(subject.take_off(plane)).to eq ("#{plane} no longer in #{subject} airport") | ||
| end |
There was a problem hiding this comment.
This is very clear - I like matching to the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erlantz Ramos
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!