Russell's Airport Challenge #2504
Conversation
|
|
||
| attr_reader :capacity | ||
|
|
||
| def initialize(capacity = DEFAULT_CAPACITY) |
There was a problem hiding this comment.
I think you can just give whatever value you want default to be here, like capacity = 1, without needing to set the DEFAULT_CAPACITY variable. As with all of my comments, apologies if I'm entirely wrong....
|
|
||
| def take_off(*) | ||
| fail "Flight cancelled due to bad weather" if bad_weather? | ||
| @airport.pop |
There was a problem hiding this comment.
I guess .pop could be tricky if we had multiple planes in the airport, as it'll always just pop the most recent entry to the airport array. FWIW, I used .delete(plane)
| end | ||
|
|
||
| def weather | ||
| @weather ||= Weather.new |
| @@ -0,0 +1,13 @@ | |||
|
|
|||
| class Weather | |||
There was a problem hiding this comment.
Oh, nice - I didn't break weather into a separate class, but definitely should have. Good compartmentalisation
| forecast >= 6 | ||
| end | ||
|
|
||
| private |
There was a problem hiding this comment.
As an open question, how come you used a private method here? I don't really understand private methods, so would be great to know
|
|
||
| it 'instructs a plane to land at an airport' do | ||
|
|
||
| # User story 1 |
There was a problem hiding this comment.
This is a nice way to make clear what you're testing. Didn't even occur to me
| # To ensure safety | ||
| # I want to prevent landing when the airport is full | ||
|
|
||
| subject.capacity.times { subject.land Plane.new } |
There was a problem hiding this comment.
Like the use of the capacity variable here. Pretty sure I hardcoded a value
| # I want to instruct a plane to land at an airport | ||
|
|
||
| # Arrange | ||
| airport = Airport.new |
There was a problem hiding this comment.
FWIW, you can use subject instead of declaring airport = Airport.new each time, when the describe for the test gives the class name
| # Arrange | ||
| airport = Airport.new | ||
| stormy_weather = Weather.new | ||
| plane = Plane.new |
There was a problem hiding this comment.
FWIW, you can do let(:plane) { Plane.new } underneath describe Airport do, then you don't have to do plane = Plane.new inside each test
Russell Morbey
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!