Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airport Challenge completed pull request #2509

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Airport Challenge completed pull request #2509

wants to merge 58 commits into from

Commits on Apr 23, 2022

  1. Add personal readme to document process

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    d6466dd View commit details
    Browse the repository at this point in the history

  2. Described Airport class

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    ef104d4 View commit details
    Browse the repository at this point in the history

  3. Describe #land to take argument

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    ad82945 View commit details
    Browse the repository at this point in the history

  4. Describe Plane class

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    1dd3e30 View commit details
    Browse the repository at this point in the history

  5. Describe land and expect it to land plane

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    c2b0bab View commit details
    Browse the repository at this point in the history

  6. Complete user story 1

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    478c49e View commit details
    Browse the repository at this point in the history

  7. Update README to use my version

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    952d126 View commit details
    Browse the repository at this point in the history

  8. Add user story 2

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    a55ea37 View commit details
    Browse the repository at this point in the history

  9. Describe Airport::TakeOff

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    9764bf6 View commit details
    Browse the repository at this point in the history

  10. Expect Airport to not contain plane after it has taken off

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    2df6d0c View commit details
    Browse the repository at this point in the history

  11. Complete user story 2

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    dc9d903 View commit details
    Browse the repository at this point in the history

  12. Add user story 3

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    8a1a800 View commit details
    Browse the repository at this point in the history

  13. Complete user story 3

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    a1fa0a5 View commit details
    Browse the repository at this point in the history

  14. Add user story 4

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    51119d0 View commit details
    Browse the repository at this point in the history

  15. Update story 3 feature test

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    f949f53 View commit details
    Browse the repository at this point in the history

  16. Add capacity and refactor to use it

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    e6d17f5 View commit details
    Browse the repository at this point in the history

  17. Refactor to use private methods

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    ce5328b View commit details
    Browse the repository at this point in the history

  18. Complete user story 4

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    a936d4b View commit details
    Browse the repository at this point in the history

  19. Add edge case plane can't take off if not at airport

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    a0bdfba View commit details
    Browse the repository at this point in the history

  20. Track and change landed state of plane

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    acabf30 View commit details
    Browse the repository at this point in the history

  21. Refactor tests to read more clearly

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    a23e9fb View commit details
    Browse the repository at this point in the history

  22. Refactor plane spec to test behaviour not state

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    bbf1a15 View commit details
    Browse the repository at this point in the history

  23. Refactor plane to use private methods

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    f9de7e6 View commit details
    Browse the repository at this point in the history

  24. Refactor airport to use private methods

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    297ebe6 View commit details
    Browse the repository at this point in the history

  25. Refactor airport_spec to test behaviour not state

    @lukestorey95
    lukestorey95 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    224587c View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2022

  1. Add edge case tests for plane state

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    44c8712 View commit details
    Browse the repository at this point in the history

  2. Add user stories 5 & 6

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    83494fd View commit details
    Browse the repository at this point in the history

  3. Add weather class and stormy? method

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    9e03049 View commit details
    Browse the repository at this point in the history

  4. Refactor weather to use private method

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    953b41e View commit details
    Browse the repository at this point in the history

  5. Add rubocop

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    701252a View commit details
    Browse the repository at this point in the history

  6. Complete user story 5

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    0a7476b View commit details
    Browse the repository at this point in the history

  7. Complete user story 5

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    dba29af View commit details
    Browse the repository at this point in the history

  8. Complete user story 6

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    786e62d View commit details
    Browse the repository at this point in the history

  9. Refactor to be more literal and adhere to SRP

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    da6ee2e View commit details
    Browse the repository at this point in the history

  10. Add instructions for installation and use

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    6875e98 View commit details
    Browse the repository at this point in the history

  11. Update completed checklist for README

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    61f1f76 View commit details
    Browse the repository at this point in the history

  12. Update program description for

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    ee3061c View commit details
    Browse the repository at this point in the history

  13. Add badges

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    7655702 View commit details
    Browse the repository at this point in the history

  14. Update badge

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    d187153 View commit details
    Browse the repository at this point in the history

  15. Update badge

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    7ed7d39 View commit details
    Browse the repository at this point in the history

  16. Update badges

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    965a7d7 View commit details
    Browse the repository at this point in the history

  17. Update badge

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    4b41790 View commit details
    Browse the repository at this point in the history

  18. Add test results

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    b87fabf View commit details
    Browse the repository at this point in the history

  19. Add tests results

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    fa9a4da View commit details
    Browse the repository at this point in the history

  20. Refactor spec for legibility

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    3280386 View commit details
    Browse the repository at this point in the history

  21. Add README to describe and document program

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    d41f6e7 View commit details
    Browse the repository at this point in the history

  22. Complete user story 1 

    Describe #land to take argument

Describe Plane class

Describe land and expect it to land plane

Complete user story 1
    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    42e4bdd View commit details
    Browse the repository at this point in the history

  23. Update README with user stories and feature tests

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    7992566 View commit details
    Browse the repository at this point in the history

  24. Complete user story 2 

    Describe Airport::TakeOff

Expect Airport to not contain plane after it has taken off

Complete user story 2
    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    48ed5d3 View commit details
    Browse the repository at this point in the history

  25. Complete user story 3 

    Complete user story 3
    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    ee3149f View commit details
    Browse the repository at this point in the history

  26. Complete user story 4 

    Add capacity and refactor to use it

Refactor to use private methods

Complete user story 4
    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    3c55b0e View commit details
    Browse the repository at this point in the history

  27. Add edge cases 

    Track and change landed state of plane

Refactor tests to read more clearly

Refactor plane spec to test behaviour not state

Refactor plane to use private methods

Refactor airport to use private methods

Refactor airport_spec to test behaviour not state

Add edge case tests for plane state
    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    ff731ab View commit details
    Browse the repository at this point in the history

  28. Complete user story 5 

    Add weather class and stormy? method

Refactor weather to use private method

Complete user story 5

Complete user story 5
    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    408efd2 View commit details
    Browse the repository at this point in the history

  29. Complete user story 6

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    a483abf View commit details
    Browse the repository at this point in the history

  30. Refactor to be more literal and adhere to SRP

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    73b2418 View commit details
    Browse the repository at this point in the history

  31. Update README with setup, installation and usage 

    Update program description for

Add badges

Add test results
    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    25031d0 View commit details
    Browse the repository at this point in the history

  32. Refactor spec for legibility

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    e7a76d7 View commit details
    Browse the repository at this point in the history

  33. Merge remote-tracking branch 'refs/remotes/origin/main'

    @lukestorey95
    lukestorey95 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    c258013 View commit details
    Browse the repository at this point in the history