Add more testing and fix some errors #25

peter279k · 2017-11-05T23:23:07Z

Thank you for providing this great math package.Here is the changed log is as follows:

Changed log

add more testing and improve code coverage.
fix some errors during the testing.
hook the coveralls and it's the code coverage service.
set the configuration for the .travis.yml.
set the dist is precise because of this issue. And it can test well in PHP 5.3.

BTW, I think the coding style should be unified.
Perhaps we can use PHP-CS-Fixer or hook the StyleCI service and set the PSR-2 coding style.
What do you think?

Thanks.

malenkiki · 2017-11-09T11:21:17Z

Whooooaa ! Thank you very very very much for this great PR!

I will check it later this day or tomorrow when I have some time.

malenkiki · 2017-11-12T20:49:23Z

src/Malenki/Math/RandomComplex.php

@@ -157,7 +157,7 @@ protected static function checkOrder($float_min, $float_max)
    public function __get($name)
    {
        if (in_array($name, array('rho', 'theta', 'r', 'i'))) {
-            return $this->$name;


Why this change?

This break the possibility to have $object->rho, or $object->theta or $object->r or $object->i direct read access.

I think directly return $name is appropriate.
If set the original code $this->$name, the variable will return null.
Because this variable is not defined in this class.

How about declare a private $name and change $this->$name to $this->name?

I see what you mean, but it is confusing, really.

But this class should be change in futur I think.

I want keep magic getter to get this values, less confusing I think.

malenkiki · 2017-11-12T21:00:48Z

tests/FactorialTest.php

+    {
+        $f = new Factorial(2);
+        $this->assertInternalType('string', $f->__toString());
+        $this->assertSame('2', $f->__toString());


... or just $this->assertSame('2', "$f"); :-)

malenkiki · 2017-11-12T21:18:31Z

tests/Number/RealTest.php

+    public function testGetShouldBePI()
+    {
+        $real = new Real(2.56);
+        $this->assertEquals(M_PI, $real->__get('pi')->__toString());


Hum… I dont know, this is strange to get pi, e, and so on from an instance. Confusing.

But, we can do that:

$real = new Real(Real::PI); $this->assertEquals(M_PI, "$real");

malenkiki · 2017-11-12T21:18:57Z

tests/Number/RealTest.php

+    public function testGetShouldBeE()
+    {
+        $real = new Real(2.56);
+        $this->assertEquals(M_E, $real->__get('e')->__toString());


Same idea as in fa42d35#r150423847

malenkiki · 2017-11-12T21:19:12Z

tests/Number/RealTest.php

+    public function testGetShouldBeEuler()
+    {
+        $real = new Real(2.56);
+        $this->assertEquals(M_EULER, $real->__get('euler')->__toString());


same as fa42d35#r150423847

malenkiki · 2017-11-12T21:20:43Z

tests/RandomComplexTest.php

+    public function testGetTheCorrectName()
+    {
+        $r = new RandomComplex();
+        $this->assertEquals('r', $r->__get('r'));


No, sorry, but this breaks original behavior. Please see fa42d35#r150422922

malenkiki · 2017-11-12T21:25:36Z

tests/Stats/ParametricTest/TTest/IndependantTest.php

+    public function testSetWithTheSampleOne()
+    {
+        $t = new Independant();
+        $t->__set('sample_1', array(1,2,3));


It is a magic setter, so it is better to test it in one shot like this:

$t->sample_1 = array(1,2,3);

malenkiki · 2017-11-12T21:26:33Z

tests/Stats/ParametricTest/TTest/IndependantTest.php

+    public function testSetWithTheSampleTwo()
+    {
+        $t = new Independant();
+        $this->assertNull($t->__set('sample_2', array(1,2,3)));


Same as fa42d35#r150424074

malenkiki · 2017-11-12T21:26:47Z

tests/Stats/ParametricTest/TTest/IndependantTest.php

+    public function testSetWithArgumentIsNoStatsInstance()
+    {
+        $t = new Independant();
+        $t->__set('sample_1', 'no');


Same as fa42d35#r150424074

malenkiki · 2017-11-12T21:29:11Z

tests/Stats/StatsTest.php

+    public function testGetWithNameIsMidRange()
+    {
+        $s = new Stats(array(1,2,3,4,5,6,7));
+        $this->assertEquals(4, $s->__get('midrange'));


It is a magic getter, so to test it, the best way is to call it:

$this->assertEquals(4, $s->midrange);

malenkiki · 2017-11-12T21:29:42Z

tests/Stats/StatsTest.php

+    public function testGetWithNameIsPlatykurtic()
+    {
+        $s = new Stats(array(1,2,3,4,5,6,7));
+        $this->assertEquals(4, $s->__get('is_platykurtic'));


Same as fa42d35#r150424191

malenkiki · 2017-11-12T21:29:58Z

tests/Stats/StatsTest.php

+    public function testGetWithNameIsLeptokurtic()
+    {
+        $s = new Stats(array(1,2,3,4,5,6,7));
+        $this->assertFalse($s->__get('is_leptokurtic'));


Same as fa42d35#r150424191

malenkiki · 2017-11-12T21:30:19Z

tests/Stats/StatsTest.php

+    public function testGetWithNameIsMesokurtic()
+    {
+        $s = new Stats(array(1,2,3,4,5,6,7));
+        $this->assertFalse($s->__get('is_mesokurtic'));


Same as fa42d35#r150424191

malenkiki · 2017-11-12T21:30:33Z

tests/Stats/StatsTest.php

+    public function testGetWithNameIsIndexOfDispersion()
+    {
+        $s = new Stats(array(1,2,3,4,5,6,7));
+        $this->assertEquals(1, $s->__get('coefficient_of_dispersion'));


Same as fa42d35#r150424191

malenkiki · 2017-11-12T21:30:45Z

tests/Stats/StatsTest.php

+    public function testGetWithNameIsPearsonsR()
+    {
+        $s = new Stats(array(1,2,3,4,5,6,7));
+        $this->assertEquals(1, $s->__get('pearsons_rho'));


Same as fa42d35#r150424191

malenkiki · 2017-11-12T21:34:29Z

tests/Unit/AngleTest.php

+    public function testGetShouldBeType()
+    {
+        $a = new Angle(4 * pi(), Angle::TYPE_RAD);
+        $this->assertEquals('rad', $a->__get('type'));


It is a magic getter, so it better to test it as it should be call:

$this->assertEquals('rad', $a->type);

malenkiki · 2017-11-12T21:47:32Z

Great PR, but I havesome comment like you have see ;-)

Many thanks!

peter279k · 2017-11-12T23:25:53Z

Hi @malenkiki, thank you for your review.
I will modify them at my available time.

Thanks!

peter279k added 6 commits November 6, 2017 06:29

add the more testing and fix some bugs during test

fa42d35

add the coveralls code coverage service

e184392

use assert type to be compatible with PHP 5.4

748cc0e

using dist is Precise

346d209

compatible with the PHP 5.3 array

3d87b0c

replace more [] with array

3b8955b

malenkiki reviewed Nov 12, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more testing and fix some errors #25

Add more testing and fix some errors #25

peter279k commented Nov 5, 2017 •

edited

Loading

malenkiki commented Nov 9, 2017

malenkiki Nov 12, 2017

peter279k Nov 12, 2017

peter279k Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki Nov 12, 2017

malenkiki commented Nov 12, 2017

peter279k commented Nov 12, 2017

Add more testing and fix some errors #25

Are you sure you want to change the base?

Add more testing and fix some errors #25

Conversation

peter279k commented Nov 5, 2017 • edited Loading

Changed log

malenkiki commented Nov 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

malenkiki commented Nov 12, 2017

peter279k commented Nov 12, 2017

peter279k commented Nov 5, 2017 •

edited

Loading