Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ho #60

Closed
wants to merge 1 commit into from
Closed

Change ho #60

wants to merge 1 commit into from

Conversation

malfet
Copy link
Owner

@malfet malfet commented Dec 26, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

@malfet
Change ho
0515a47 
[ghstack-poisoned]
@malfet malfet mentioned this pull request Dec 26, 2023
Closed
malfet added a commit that referenced this pull request Dec 26, 2023
@malfet
Change ho
acb74c8 
ghstack-source-id: 718b3617ee9d0a30f8351fb261eda19437d86869
Pull Request resolved: #60
@malfet
Copy link
Owner Author

malfet commented Dec 26, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Owner Author

malfet commented Dec 26, 2023

@pytorchbot merge -f "What?"

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 26, 2023

You need to provide a reason for using force merge, in the format @pytorchbot merge -f 'Explanation'.
The explanation needs to be clear on why this is needed. Here are some good examples:

  • Bypass checks due to unrelated upstream failures from ...
  • This is a minor fix to ..., which shouldn't break anything
  • This is pre-tested in a previous CI run
  • Bypass flaky ... check

@malfet
Copy link
Owner Author

malfet commented Dec 26, 2023

@pytorchbot merge -f "What"

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 26, 2023

You need to provide a reason for using force merge, in the format @pytorchbot merge -f 'Explanation'.
The explanation needs to be clear on why this is needed. Here are some good examples:

  • Bypass checks due to unrelated upstream failures from ...
  • This is a minor fix to ..., which shouldn't break anything
  • This is pre-tested in a previous CI run
  • Bypass flaky ... check

@malfet
Copy link
Owner Author

malfet commented Dec 26, 2023

@pytorchbot merge -f 'Explanation'

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 26, 2023

You need to provide a reason for using force merge, in the format @pytorchbot merge -f 'Explanation'.
The explanation needs to be clear on why this is needed. Here are some good examples:

  • Bypass checks due to unrelated upstream failures from ...
  • This is a minor fix to ..., which shouldn't break anything
  • This is pre-tested in a previous CI run
  • Bypass flaky ... check

@malfet
Copy link
Owner Author

malfet commented Dec 26, 2023

@pytorchbot merge -f 'Bypass flaky test'

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Owner Author

malfet commented Dec 26, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: No rule found to match PR. Please [report]https://github.com/malfet/deleteme/issues/new?labels=module%3A%20ci&template=bug-report.yml this issue to DevX team.

Details for Dev Infra team Raised by workflow job

Failing merge rule: Text changes

@malfet malfet mentioned this pull request Dec 26, 2023
Open
@malfet
Copy link
Owner Author

malfet commented Dec 26, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Owner Author

malfet commented Dec 27, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Owner Author

malfet commented Dec 27, 2023

@pytorchbot megre

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 27, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'megre' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'close')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,close} ...

Try @pytorchbot --help for more info.

pytorchmergebot added a commit that referenced this pull request Dec 27, 2023
@pytorchmergebot
Revert "Change ho (#60)"
68b56e3 
This reverts commit b0bbb01.

Reverted #60 on behalf of https://github.com/malfet due to  I want to revert this stack ([comment](#59 (comment)))
pytorchmergebot referenced this pull request Dec 27, 2023
@malfet @pytorchmergebot
Change ha (#59)
0f9a3e1 
Pull Request resolved: #59
Approved by:
@pytorchmergebot
Copy link
Collaborator

@malfet your PR has been successfully reverted.

@malfet
Copy link
Owner Author

malfet commented Dec 27, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Owner Author

malfet commented Dec 27, 2023

@pytorchbot revert -m "I want it" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@malfet your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Dec 27, 2023
@pytorchmergebot
Revert "Change ho (#60)"
c4f1cc5 
This reverts commit 389a0f6.

Reverted #60 on behalf of https://github.com/malfet due to I want it ([comment](#60 (comment)))
@malfet
Copy link
Owner Author

malfet commented Dec 27, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged reverted topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malfet @pytorchmergebot